Bug 138751

Summary: [iOS] QuartzCore SPI not available in public SDK
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ddkilzer, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: iOS 8.1   
Bug Depends on: 138709    
Bug Blocks: 136487, 138756    
Attachments:
Description Flags
Patch
none
Patch ddkilzer: review+

Description Daniel Bates 2014-11-14 11:46:52 PST 
The iOS WebKit port makes use of the private headers from the QuartzCore framework. Towards building the port using the public SDK, we should forward declare the applicable QuartzCore SPI.
Comment 1 Daniel Bates 2014-11-14 11:49:49 PST 
Created attachment 241610 [details]
Patch
Comment 2 Daniel Bates 2014-11-14 13:16:33 PST 
Created attachment 241617 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2014-11-14 15:54:08 PST 
Comment on attachment 241617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241617&action=review

r=me

> Source/WebCore/platform/ios/LegacyTileCache.mm:31
> +#include "CoreGraphicsSPI.h"

Should this have been part of another patch?
Comment 4 Daniel Bates 2014-11-17 09:38:18 PST 
(In reply to comment #3)
> 
> > Source/WebCore/platform/ios/LegacyTileCache.mm:31
> > +#include "CoreGraphicsSPI.h"
> 
> Should this have been part of another patch?

No, this is appropriate for this patch. We need to fix <rdar://problem/18985152> so that we can simply include <QuartzCore/QuartzCorePrivate.h> from QuartzCoreSPI.h instead of explicitly including individual QuartzCore headers. Then we can remove this line (#include "CoreGraphicsSPI.h") since QuartzCorePrivate.h ultimately includes the appropriate CoreGraphics private header that defines CGSRegionObj.
Comment 5 Daniel Bates 2014-11-17 09:44:39 PST 
Committed r176204: <http://trac.webkit.org/changeset/176204>
Comment 6 Daniel Bates 2014-11-17 10:23:01 PST 
Committed Mac build fix in <https://trac.webkit.org/changeset/176205>.