Bug 138724

Summary:

Clean up OwnPtr and PassOwnPtr in some of JS classes

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

JavaScriptCore

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for ews	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Patch	none
Patch for win	none
Patch	none
Patch	none
Patch	none

Gyuyoung Kim

Reported 2014-11-13 20:03:17 PST

SSIA

Attachments
Patch (22.00 KB, patch) 2014-11-13 20:04 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for ews (23.31 KB, patch) 2014-11-13 22:55 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (678.37 KB, application/zip) 2014-11-14 00:24 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (406.16 KB, application/zip) 2014-11-14 03:09 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (550.26 KB, application/zip) 2014-11-14 03:18 PST, Build Bot	no flags	Details
Patch (12.80 KB, patch) 2014-11-17 01:17 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch for win (12.85 KB, patch) 2014-11-17 06:09 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (13.85 KB, patch) 2014-11-21 07:27 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (13.85 KB, patch) 2014-11-21 17:04 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (13.96 KB, patch) 2014-11-21 17:47 PST, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2014-11-13 20:04:24 PST

Created attachment 241537 [details] Patch

Gyuyoung Kim

Comment 2 2014-11-13 22:55:27 PST

Created attachment 241558 [details] Patch for ews

Build Bot

Comment 3 2014-11-14 00:24:16 PST

Comment on attachment 241558 [details] Patch for ews Attachment 241558 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4703020218580992 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2014-11-14 00:24:18 PST

Created attachment 241562 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-11-14 03:09:03 PST

Comment on attachment 241558 [details] Patch for ews Attachment 241558 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5932307504431104 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2014-11-14 03:09:10 PST

Created attachment 241572 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-11-14 03:18:20 PST

Comment on attachment 241558 [details] Patch for ews Attachment 241558 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5647894770089984 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2014-11-14 03:18:23 PST

Created attachment 241573 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Gyuyoung Kim

Comment 9 2014-11-17 01:17:13 PST

Created attachment 241697 [details] Patch

Gyuyoung Kim

Comment 10 2014-11-17 06:09:41 PST

Created attachment 241706 [details] Patch for win

Gyuyoung Kim

Comment 11 2014-11-21 07:27:50 PST

Created attachment 242044 [details] Patch

Gyuyoung Kim

Comment 12 2014-11-21 17:04:23 PST

Created attachment 242095 [details] Patch

Gyuyoung Kim

Comment 13 2014-11-21 17:47:08 PST

Created attachment 242096 [details] Patch

WebKit Commit Bot

Comment 14 2014-11-22 17:55:08 PST

Comment on attachment 242096 [details] Patch Rejecting attachment 242096 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 242096, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/6739234148843520

Gyuyoung Kim

Comment 15 2014-11-22 20:37:05 PST

Comment on attachment 242096 [details] Patch Clearing flags on attachment: 242096 Committed r176508: <http://trac.webkit.org/changeset/176508>

Gyuyoung Kim

Comment 16 2014-11-22 20:37:13 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.