Bug 138718

Summary: Compute the selector specificity as we match simple selectors
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
none
Patch
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
none
Patch none

Benjamin Poulain
Reported 2014-11-13 16:34:01 PST
Compute the selector specificity as we match simple selectors
Attachments
Patch (20.66 KB, patch)
2014-11-13 16:36 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (663.72 KB, application/zip)
2014-11-13 20:10 PST, Build Bot 		no flags
Details
Patch (20.80 KB, patch)
2014-11-13 20:39 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (590.75 KB, application/zip)
2014-11-13 21:48 PST, Build Bot 		no flags
Details
Patch (20.80 KB, patch)
2014-11-14 15:59 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-11-13 16:36:17 PST
Created attachment 241518 [details] Patch
Chris Dumez
Comment 2 2014-11-13 17:49:04 PST
Comment on attachment 241518 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241518&action=review > Source/WebCore/css/CSSSelector.cpp:120 > +unsigned CSSSelector::addSpecificity(unsigned a, unsigned b) plural? > Source/WebCore/css/SelectorChecker.cpp:1039 > + unsigned ignoreSpecificity = 0; "ignoredSpecificity".
Build Bot
Comment 3 2014-11-13 20:10:39 PST
Comment on attachment 241518 [details] Patch Attachment 241518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6460825778782208 Number of test failures exceeded the failure limit.
Build Bot
Comment 4 2014-11-13 20:10:43 PST
Created attachment 241539 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Benjamin Poulain
Comment 5 2014-11-13 20:39:42 PST
Created attachment 241546 [details] Patch
Build Bot
Comment 6 2014-11-13 21:48:01 PST
Comment on attachment 241546 [details] Patch Attachment 241546 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5367891893420032 Number of test failures exceeded the failure limit.
Build Bot
Comment 7 2014-11-13 21:48:03 PST
Created attachment 241554 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Benjamin Poulain
Comment 8 2014-11-14 15:59:07 PST
Created attachment 241636 [details] Patch
Benjamin Poulain
Comment 9 2014-11-14 18:32:30 PST
Comment on attachment 241636 [details] Patch Clearing flags on attachment: 241636 Committed r176152: <http://trac.webkit.org/changeset/176152>
Benjamin Poulain
Comment 10 2014-11-14 18:32:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.