Bug 138708

Summary: Change X86/64 JIT probes to save/restore xmm regs as double instead of __m128
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mmirman, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138671    
Attachments:
Description Flags
the patch.
msaboff: review+
follow up patch. msaboff: review+

Mark Lam
Reported 2014-11-13 14:35:58 PST
The JIT code only uses the xmm regs as double registers. This patch changes the storage types of the FP registers in X86Assembler.h to double instead of __m128, and updates the X86 and X86_64 JIT probe implementations accordingly. Also made some minor cosmetic changes in the output of the probe dump functions.
Attachments
the patch. (19.56 KB, patch)
2014-11-13 14:42 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
follow up patch. (1.68 KB, patch)
2014-11-13 15:38 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-11-13 14:42:36 PST
Created attachment 241502 [details] the patch.
Michael Saboff
Comment 2 2014-11-13 14:54:22 PST
Comment on attachment 241502 [details] the patch. r=me
Mark Lam
Comment 3 2014-11-13 15:00:49 PST
Thanks. Landed in r176095: <http://trac.webkit.org/r176095>.
Joseph Pecoraro
Comment 4 2014-11-13 15:21:51 PST
Comment on attachment 241502 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241502&action=review > Source/JavaScriptCore/assembler/X86Assembler.h:75 > // the storing still expects a __m128 slot. This will be changed when the JIT > // probe code is updated later to reflect the JITs' usage of these registers. > #define FOR_EACH_CPU_FPREGISTER(V) \ Looks like the comment above this is now incorrect?
Mark Lam
Comment 5 2014-11-13 15:29:34 PST
Comment on attachment 241502 [details] the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=241502&action=review >> Source/JavaScriptCore/assembler/X86Assembler.h:75 >> #define FOR_EACH_CPU_FPREGISTER(V) \ > > Looks like the comment above this is now incorrect? Arggg ... thanks for catching this. Will fix.
Mark Lam
Comment 6 2014-11-13 15:38:31 PST
Created attachment 241512 [details] follow up patch.
Michael Saboff
Comment 7 2014-11-13 15:41:40 PST
Comment on attachment 241512 [details] follow up patch. r=me
Mark Lam
Comment 8 2014-11-13 15:45:08 PST
Thanks for the review. Follow up landed in r176100: <http://trac.webkit.org/r176100>.
Note You need to log in before you can comment on or make changes to this bug.