Change X86/64 JIT probes to save/restore xmm regs as double instead of __m128

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Lam]

The JIT code only uses the xmm regs as double registers.  This patch changes the storage types of the FP registers in X86Assembler.h to double instead of __m128, and updates the X86 and X86_64 JIT probe implementations accordingly.

Also made some minor cosmetic changes in the output of the probe dump functions.

[Mark Lam]

Created attachment 241502 [details]
the patch.

[Michael Saboff]

Comment on attachment 241502 [details]
the patch.

r=me

[Mark Lam]

Thanks.  Landed in r176095: <http://trac.webkit.org/r176095>.

[Joseph Pecoraro]

Comment on attachment 241502 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241502&action=review

> Source/JavaScriptCore/assembler/X86Assembler.h:75
>  // the storing still expects a __m128 slot. This will be changed when the JIT
>  // probe code is updated later to reflect the JITs' usage of these registers.
>  #define FOR_EACH_CPU_FPREGISTER(V) \

Looks like the comment above this is now incorrect?

[Mark Lam]

Comment on attachment 241502 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=241502&action=review

>> Source/JavaScriptCore/assembler/X86Assembler.h:75
>>  #define FOR_EACH_CPU_FPREGISTER(V) \
> 
> Looks like the comment above this is now incorrect?

Arggg ... thanks for catching this.  Will fix.

[Mark Lam]

Created attachment 241512 [details]
follow up patch.

[Michael Saboff]

Comment on attachment 241512 [details]
follow up patch.

r=me

[Mark Lam]

Thanks for the review.  Follow up landed in r176100: <http://trac.webkit.org/r176100>.