| Summary: | Tests ported from W3C canvas tests suites need to be fixed for WebKit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 138324 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Said Abou-Hallawa
2014-11-12 14:42:57 PST
More failures: imported/w3c/canvas/security.drawImage.canvas.html imported/w3c/canvas/security.drawImage.image.html imported/w3c/canvas/security.pattern.canvas.fillStyle.html imported/w3c/canvas/security.pattern.canvas.strokeStyle.html imported/w3c/canvas/security.pattern.create.html imported/w3c/canvas/security.pattern.cross.html imported/w3c/canvas/security.pattern.image.fillStyle.html imported/w3c/canvas/security.pattern.image.strokeStyle.html imported/w3c/canvas/security.reset.html One more failure imported/w3c/canvas/security.pattern.canvas.timing.html Two more failures: imported/w3c/canvas/2d.drawImage.negativedest.html imported/w3c/canvas/2d.drawImage.nowrap.html Created attachment 241656 [details]
Patch
Comment on attachment 241656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241656&action=review > LayoutTests/imported/w3c/ChangeLog:10 > + - missing png file which is referenced by four test files. Good to fix. > LayoutTests/imported/w3c/ChangeLog:11 > + - missing closing parenthesis in two other tests files. I don’t think this is correct. > LayoutTests/imported/w3c/canvas/2d.fillStyle.parse.rgb-eof.html:26 > -ctx.fillStyle = 'rgb(0, 255, 0'; > +ctx.fillStyle = 'rgb(0, 255, 0)'; I think this omitted parenthesis is intentional. Note that name of the test with its suffix "-eof". If lack of parenthesis wasn’t the thing being tested, then what does the “eof” in the test’s name mean? > LayoutTests/imported/w3c/canvas/2d.fillStyle.parse.rgba-eof.html:26 > -ctx.fillStyle = 'rgba(0, 255, 0, 1'; > +ctx.fillStyle = 'rgba(0, 255, 0, 1)'; I think this omitted parenthesis is intentional. Note that name of the test with its suffix "-eof". If lack of parenthesis wasn’t the thing being tested, then what does the “eof” in the test’s name mean? |