Bug 138661

Summary: Rename USE(MASM_PROBE) to ENABLE(MASM_PROBE)
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138660    
Attachments:
Description Flags
the patch. msaboff: review+

Mark Lam
Reported 2014-11-12 09:25:26 PST
Also move the switch for enabling the use of MASM_PROBE from JavaScriptCore config.h to WTF's Platform.h. This ensures that the setting is consistently applied even when building WebCore parts as well. This is a step towards refactoring the probe mechanism to add printing functionality in JITted code for debugging
Attachments
the patch. (17.93 KB, patch)
2014-11-12 09:36 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-11-12 09:36:34 PST
Created attachment 241430 [details] the patch.
Michael Saboff
Comment 2 2014-11-12 10:12:12 PST
Comment on attachment 241430 [details] the patch. r=me
Mark Lam
Comment 3 2014-11-12 12:11:40 PST
Thanks for the review. Landed in r176031: <http://trac.webkit.org/r176031>.
Note You need to log in before you can comment on or make changes to this bug.