Bug 138651 – Change DFG to use scope operand for op_resolve_scope

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Saboff]

The DFG should use the scope operand provided by op_resolve_scope.

[Michael Saboff]

Created attachment 241412 [details]
Patch

[Geoffrey Garen]

Comment on attachment 241412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241412&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2304
> +Node* ByteCodeParser::getScope(VirtualRegister scope, unsigned skipCount)

Strange to call a function named "get scope" and pass it a thing named "scope".

A better name for this argument would be scopeChain, since it's the list of possible scopes, but the head is not necessarily the one you want to get.

[Michael Saboff]

(In reply to comment #2)
> Comment on attachment 241412 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241412&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2304
> > +Node* ByteCodeParser::getScope(VirtualRegister scope, unsigned skipCount)
> 
> Strange to call a function named "get scope" and pass it a thing named
> "scope".
> 
> A better name for this argument would be scopeChain, since it's the list of
> possible scopes, but the head is not necessarily the one you want to get.

I changed the argument's name to scopeChain.

[Michael Saboff]

Committed r176005: <http://trac.webkit.org/changeset/176005>