Bug 138650

Summary:

Implement the matching for :nth-last-child(An+B of selector-list)

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, kling, rmondello

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Benjamin Poulain

Reported 2014-11-11 19:45:36 PST

Implement the matching for :nth-last-child(An+B of selector-list)

Attachments
Patch (62.10 KB, patch) 2014-11-11 19:55 PST, Benjamin Poulain	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-11-11 19:55:53 PST

Created attachment 241411 [details] Patch

Andreas Kling

Comment 2 2014-11-13 12:39:44 PST

Comment on attachment 241411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241411&action=review r=me > Source/WebCore/dom/Node.cpp:678 > + if (is<Element>(ancestor) && downcast<Element>(ancestor)->childrenAffectedByPropertyBasedBackwardPositionalRules()) { is<Element>(ancestor) will do an unnecessary null check here; you probably want is<Element>(*ancestor)

Benjamin Poulain

Comment 3 2014-11-13 13:00:29 PST

Committed r176084: <http://trac.webkit.org/changeset/176084>

Chris Dumez

Comment 4 2014-11-13 13:07:10 PST

Comment on attachment 241411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241411&action=review >> Source/WebCore/dom/Node.cpp:678 >> + if (is<Element>(ancestor) && downcast<Element>(ancestor)->childrenAffectedByPropertyBasedBackwardPositionalRules()) { > > is<Element>(ancestor) will do an unnecessary null check here; you probably want is<Element>(*ancestor) yes, and we usually do downcast<Element>(*ancestor).xxx() as well.

Note You need to log in before you can comment on or make changes to this bug.