Bug 138649

Summary: Move Modules/websockets to std::unique_ptr
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 128007    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Gyuyoung Kim 2014-11-11 19:26:33 PST 
SSIA
Comment 1 Gyuyoung Kim 2014-11-11 19:27:17 PST 
Created attachment 241409 [details]
Patch
Comment 2 Chris Dumez 2014-11-11 20:42:37 PST 
Comment on attachment 241409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241409&action=review

r=me with nits.

> Source/WebCore/ChangeLog:3
> +        Move Modules/websoeckets to std::unique_ptr

"websockets"

> Source/WebCore/Modules/websockets/WebSocketDeflater.h:52
> +    WebSocketDeflater(int windowBits, ContextTakeOverMode = TakeOverContext);

nit explicit?
Comment 3 Gyuyoung Kim 2014-11-11 21:34:38 PST 
Created attachment 241413 [details]
Patch for landing
Comment 4 Gyuyoung Kim 2014-11-11 22:55:15 PST 
(In reply to comment #2)
> Comment on attachment 241409 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241409&action=review
> 
> r=me with nits.
> 
> > Source/WebCore/ChangeLog:3
> > +        Move Modules/websoeckets to std::unique_ptr
> 
> "websockets"
> 
> > Source/WebCore/Modules/websockets/WebSocketDeflater.h:52
> > +    WebSocketDeflater(int windowBits, ContextTakeOverMode = TakeOverContext);
> 
> nit explicit?

Fixed all ! Thanks.
Comment 5 WebKit Commit Bot 2014-11-11 23:33:18 PST 
Comment on attachment 241413 [details]
Patch for landing

Clearing flags on attachment: 241413

Committed r176009: <http://trac.webkit.org/changeset/176009>
Comment 6 WebKit Commit Bot 2014-11-11 23:33:22 PST 
All reviewed patches have been landed.  Closing bug.