Bug 138625

Summary: [JSC] Add more options to control FTL CodeGen
Product: WebKit Reporter: Juergen Ributzka <juergen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review-, commit-queue: commit-queue-

Description Juergen Ributzka 2014-11-11 13:10:00 PST 
[JSC] Add more options to control FTL CodeGen
Comment 1 Juergen Ributzka 2014-11-11 13:10:28 PST 
Created attachment 241373 [details]
Patch
Comment 2 Juergen Ributzka 2014-11-11 13:12:42 PST 
Created attachment 241375 [details]
Patch
Comment 3 Geoffrey Garen 2014-11-11 13:15:38 PST 
Comment on attachment 241375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241375&action=review

r=me

> Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:73
> +        Vector<const char *, 4> args;

WebKit style is "char*".
Comment 4 Juergen Ributzka 2014-11-11 13:18:17 PST 
Created attachment 241376 [details]
Patch
Comment 5 Geoffrey Garen 2014-11-11 13:21:14 PST 
Comment on attachment 241376 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-11-13 18:34:56 PST 
Comment on attachment 241376 [details]
Patch

Rejecting attachment 241376 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
nchor.dia -c /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llvm/library/LLVMAnchor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMAnchor.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMExports.o llvm/library/LLVMExports.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5704957705584640
Comment 7 Geoffrey Garen 2015-03-04 11:52:57 PST 
Comment on attachment 241376 [details]
Patch

Let's come up with a way to adopt this API conditionally that doesn't break the build or harm performance when using older versions of LLVM.
Comment 8 Filip Pizlo 2015-04-07 11:23:59 PDT 

*** This bug has been marked as a duplicate of bug 143489 ***