Bug 138625

Summary: [JSC] Add more options to control FTL CodeGen
Product: WebKit Reporter: Juergen Ributzka <juergen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: commit-queue, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review-, commit-queue: commit-queue-

Juergen Ributzka
Reported 2014-11-11 13:10:00 PST
[JSC] Add more options to control FTL CodeGen
Attachments
Patch (4.69 KB, patch)
2014-11-11 13:10 PST, Juergen Ributzka 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2014-11-11 13:12 PST, Juergen Ributzka 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2014-11-11 13:18 PST, Juergen Ributzka 		ggaren: review-
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Juergen Ributzka
Comment 1 2014-11-11 13:10:28 PST
Created attachment 241373 [details] Patch
Juergen Ributzka
Comment 2 2014-11-11 13:12:42 PST
Created attachment 241375 [details] Patch
Geoffrey Garen
Comment 3 2014-11-11 13:15:38 PST
Comment on attachment 241375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241375&action=review r=me > Source/JavaScriptCore/llvm/InitializeLLVMPOSIX.cpp:73 > + Vector<const char *, 4> args; WebKit style is "char*".
Juergen Ributzka
Comment 4 2014-11-11 13:18:17 PST
Created attachment 241376 [details] Patch
Geoffrey Garen
Comment 5 2014-11-11 13:21:14 PST
Comment on attachment 241376 [details] Patch r=me
WebKit Commit Bot
Comment 6 2014-11-13 18:34:56 PST
Comment on attachment 241376 [details] Patch Rejecting attachment 241376 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: nchor.dia -c /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/llvm/library/LLVMAnchor.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMAnchor.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/llvmForJSC.build/Objects-normal/x86_64/LLVMExports.o llvm/library/LLVMExports.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5704957705584640
Geoffrey Garen
Comment 7 2015-03-04 11:52:57 PST
Comment on attachment 241376 [details] Patch Let's come up with a way to adopt this API conditionally that doesn't break the build or harm performance when using older versions of LLVM.
Filip Pizlo
Comment 8 2015-04-07 11:23:59 PDT
*** This bug has been marked as a duplicate of bug 143489 ***
Note You need to log in before you can comment on or make changes to this bug.