Bug 138581

Summary:

Test that complex and fast text codepaths measure the same width

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, jonlee, mitz, rniwa, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Myles C. Maxfield

Reported 2014-11-10 14:54:15 PST

Test that complext and fast text codepaths measure the same width

Attachments
Patch (2.21 KB, patch) 2014-11-10 14:55 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2014-11-10 14:55:01 PST

Created attachment 241310 [details] Patch

mitz

Comment 2 2014-11-10 15:12:59 PST

I suspect that this test would have passed even with a change such as the one introduced by <http://trac.webkit.org/r175813>, because tests run in an environment where kerning and ligatures are disabled by default. Another good way to test that the two code paths agree is to use the --complex-text option of run-webkit-tests.

Myles C. Maxfield

Comment 3 2014-11-10 15:37:51 PST

You're right; the test passes. This whole "not testing what we ship" thing is pretty terrible.

Simon Fraser (smfr)

Comment 4 2014-11-10 15:38:29 PST

Should we add a way that a test can opt into the complex text path?

Myles C. Maxfield

Comment 5 2014-11-10 16:12:02 PST

This isn't actually about the fast vs slow code paths, it's about how kerning and ligatures are turned off. Instead of opting in, I think it's time we enabled K&L for all tests by default.

mitz

Comment 6 2014-11-10 16:46:06 PST

(In reply to comment #5) > This isn't actually about the fast vs slow code paths, it's about how > kerning and ligatures are turned off. Instead of opting in, I think it's > time we enabled K&L for all tests by default. I agree. (Note that we do have some tests that enable kerning and/or ligatures using the relevant CSS properties, and we even have some tests that force the complex code path to be taken).

WebKit Commit Bot

Comment 7 2014-11-10 17:37:20 PST

Comment on attachment 241310 [details] Patch Clearing flags on attachment: 241310 Committed r175843: <http://trac.webkit.org/changeset/175843>

WebKit Commit Bot

Comment 8 2014-11-10 17:37:24 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.