Bug 138568

Summary: Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
Patch thorton: review+

Description Tim Horton 2014-11-10 11:46:18 PST 
We can on occasion (with an explicit selection, usually) have an image in the LookUp attributed string; we don't know how to serialize an attributed string with a image in it, though!

In other cases, we round-trip through RTFD. This can lead to bizarre behavior with SVG, etc. (things that AppKit doesn't know how to render), but at least it doesn't crash anymore.
Comment 1 Tim Horton 2014-11-10 11:46:52 PST 
<rdar://problem/18904600>
Comment 2 Tim Horton 2014-11-10 11:51:50 PST 
Created attachment 241295 [details]
patch
Comment 3 Tim Horton 2014-11-10 22:29:34 PST 
Comment on attachment 241295 [details]
patch

Sam thinks we should just strip images instead.
Comment 4 Anders Carlsson 2014-11-11 08:50:05 PST 
(In reply to comment #3)
> Comment on attachment 241295 [details]
> patch
> 
> Sam thinks we should just strip images instead.

Sounds good to me.
Comment 5 Beth Dakin 2014-11-20 13:48:59 PST 
Created attachment 241976 [details]
Patch
Comment 6 Beth Dakin 2014-11-20 14:04:13 PST 
http://trac.webkit.org/changeset/176412