Bug 138567 – Some functions on DictionaryLookup.h should just be generic functions on Range or VisiblePosition

• Component: HTML Editing
• Status: RESOLVED FIXED

[Beth Dakin]

Some functions on DictionaryLookup.h should just be generic functions on Range or VisiblePosition, specifically isPositionInRange() and shouldUseSelection()

[Beth Dakin]

And rangeExpandedAroundPositionByCharacters()! Which is code originally stolen from Editor, according to Tim.

[Tim Horton]

Created attachment 259191 [details]
Patch

[Tim Horton]

http://trac.webkit.org/changeset/188565

[Said Abou-Hallawa]

Comment on attachment 259191 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259191&action=review

> Source/WebCore/dom/Range.cpp:1963
> +bool Range::contains(const VisiblePosition& position) const

Can't we be more generic here and have the prototype of this function: bool Range::contains(const VisiblePosition &start, const VisiblePosition &end)?

> Source/WebCore/editing/mac/DictionaryLookup.mm:61
> +    return selectedRange->contains(position);

To check whether a VisiblePosition is in a range of VisibleSelection, is not it sufficient to call Range::isPointInRange()?
What is the difference if VisiblePosition is at the boundary of the range of VisibleSelection when:
1. calling Range::isPointInRange()
2. calling the deleted function isPositionInRange()
3. calling Range::contains()