Bug 13854

Summary:

Port of commit 667785 from kjs

Product:

WebKit

Reporter:

Luciano Montanaro <mikelima>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

porten

Priority:

Version:

523.x (Safari 3)

Hardware:

Other

OS:

OS X 10.4

Attachments:

Description	Flags
The two-line patch	darin: review-
Result of the localeCompare testcases with IE6	none
patch with updated test case	darin: review+

Luciano Montanaro

Reported 2007-05-24 02:27:49 PDT

The log for that change says: "fixed special no-args case I discovered when writing tests more or less accidentally".

Attachments
The two-line patch (378 bytes, patch) 2007-05-24 02:29 PDT, Luciano Montanaro	darin: review-	Details Formatted Diff Diff
Result of the localeCompare testcases with IE6 (3.09 KB, text/plain) 2007-05-25 01:02 PDT, Luciano Montanaro	no flags	Details
patch with updated test case (3.87 KB, patch) 2007-05-25 11:37 PDT, Sam Weinig	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Luciano Montanaro

Comment 1 2007-05-24 02:29:43 PDT

Created attachment 14700 [details] The two-line patch The patch for the backported fix

David Kilzer (:ddkilzer)

Comment 2 2007-05-24 05:16:14 PDT

Comment on attachment 14700 [details] The two-line patch Please set the "review?" flag on patches you'd like reviewed. Thanks! This patch also needs a ChangeLog and a layout test. See: http://webkit.org/coding/contributing.html

Darin Adler

Comment 3 2007-05-24 09:42:03 PDT

Comment on attachment 14700 [details] The two-line patch Needs a test.

Darin Adler

Comment 4 2007-05-24 09:47:21 PDT

Comment on attachment 14700 [details] The two-line patch Patch is great. We need both a change log and a layout test for this, as Dave says.

Luciano Montanaro

Comment 5 2007-05-25 01:02:00 PDT

Created attachment 14712 [details] Result of the localeCompare testcases with IE6 testcase log showing IE6 has a different behavior vs. Firefox.

Harri Porten

Comment 6 2007-05-25 09:23:16 PDT

Given the IE6 test results that Luciano kindly attached to this report I suddenly developed some doubts about this patch. I only discovered this special case by accident when writing a test. But if Firefox is the only browser showing this behavior I am tempted to remove it again from Konqueror. Might base this decision on what you guys do, though.

Sam Weinig

Comment 7 2007-05-25 11:37:32 PDT

Created attachment 14728 [details] patch with updated test case This patch includes the changes and updates fast/js/kde/StringObject.html to match kde which include new localeCompare tests. It should be noted that both IE and Opera do not match this behavior, but Firefox does.

Sam Weinig

Comment 8 2007-05-25 11:38:45 PDT

My concerns mirror Harri's.

Darin Adler

Comment 9 2007-05-26 08:45:57 PDT

Comment on attachment 14728 [details] patch with updated test case r=me

Sam Weinig

Comment 10 2007-05-26 15:21:46 PDT

Landed in r21806.

Note You need to log in before you can comment on or make changes to this bug.