Bug 13849
| Summary: | REGRESSION: History node not being created after javascript document.location is set | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Rachael Worthington (cheers) <rachael> |
| Component: | History | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | mbritto, sroret |
| Priority: | P1 | Keywords: | Regression |
| Version: | 523.x (Safari 3) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://forums.worldofwarcraft.com/board.html?forumId=10001&sid=1 | ||
Rachael Worthington (cheers)
Steps to Reproduce:
1. navigate to the provided URL. This is the General Forum of the WoW forums
2. select a different forum from the drop-down menu at the top of the boards. (This should create a history node, and doesn't, which is the issue!)
3. click on a thread within your new forums, let it load
4. click back.
Expected Results: you should be looking at the list of threads in whichever forum you navigated to.
Actual Results: the General Forum loads again.
The behavior regressed between the nightly for revision 20809 and 20814. If I had to guess, I'd say that the problem was probably in http://trac.webkit.org/projects/webkit/changeset/20813
Talking to bradee-oh about it in IRC, he said:
[5:35pm] bradee-oh: cheers: I think the problem is we're not detecting the forum selector as a userGesture
[5:35pm] bradee-oh: cheers: because if we do see it as a user gesture, we treat it as a normal load and add an entry
[5:36pm] bradee-oh: I think
I was thinking it might be a dupe of http://bugs.webkit.org/show_bug.cgi?id=9148 but bradee disagrees so here's a new bug for the issue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Maxime BRITTO
I can no longer reproduce this bug with the modifications I made in the patch for the bug 14147 http://bugs.webkit.org/show_bug.cgi?id=14147
I think the bug was the same. My patch hasn't been reviewed still, we can tell more when it'll be.
Andrew Wellington
*** This bug has been marked as a duplicate of 14147 ***