Bug 138479

Summary:

Drop useless HTMLElement::isURLAttribute() override

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, kling, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2014-11-06 15:17:21 PST

Drop useless HTMLElement::isURLAttribute() override as it is doing nothing but call the parent class' isURLAttribute().

Comment 1 Chris Dumez 2014-11-06 15:19:24 PST

Created attachment 241134 [details]
Patch

Comment 2 Mark Lam 2014-11-07 01:37:24 PST

Comment on attachment 241134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241134&action=review

r=me with comment fix.

> Source/WebCore/ChangeLog:9
> +        nothing but call the parent class' isURLAttribute().

typo: /call/calling/

Comment 3 Chris Dumez 2014-11-07 09:42:13 PST

Created attachment 241188 [details]
Patch

Comment 4 WebKit Commit Bot 2014-11-07 10:28:37 PST

Comment on attachment 241188 [details]
Patch

Clearing flags on attachment: 241188

Committed r175752: <http://trac.webkit.org/changeset/175752>

Comment 5 WebKit Commit Bot 2014-11-07 10:28:42 PST

All reviewed patches have been landed.  Closing bug.