Bug 138479

Summary: Drop useless HTMLElement::isURLAttribute() override
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-06 15:17:21 PST
Drop useless HTMLElement::isURLAttribute() override as it is doing nothing but call the parent class' isURLAttribute().
Attachments
Patch (2.11 KB, patch)
2014-11-06 15:19 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2014-11-07 09:42 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-06 15:19:24 PST
Created attachment 241134 [details] Patch
Mark Lam
Comment 2 2014-11-07 01:37:24 PST
Comment on attachment 241134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241134&action=review r=me with comment fix. > Source/WebCore/ChangeLog:9 > + nothing but call the parent class' isURLAttribute(). typo: /call/calling/
Chris Dumez
Comment 3 2014-11-07 09:42:13 PST
Created attachment 241188 [details] Patch
WebKit Commit Bot
Comment 4 2014-11-07 10:28:37 PST
Comment on attachment 241188 [details] Patch Clearing flags on attachment: 241188 Committed r175752: <http://trac.webkit.org/changeset/175752>
WebKit Commit Bot
Comment 5 2014-11-07 10:28:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.