| Summary: | Don't send identifierForInitialRequest callback method for request with DoNotSendCallbacks option. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||
| Component: | WebCore Misc. | Assignee: | Yongjun Zhang <yongjun_zhang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, buildbot, commit-queue, ddkilzer, japhet, mitz, psolanki, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | iOS 8.1 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yongjun Zhang
2014-11-06 13:21:51 PST
Created attachment 241129 [details]
Remove iOS specific lines in ResourceLoader.cpp since they are not needed any more.
Attachment 241129 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:16: Line contains tab character. [whitespace/tab] [5]
Total errors found: 8 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 241129 [details] Remove iOS specific lines in ResourceLoader.cpp since they are not needed any more. View in context: https://bugs.webkit.org/attachment.cgi?id=241129&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=138473 Add the radar number here. > Source/WebCore/loader/ResourceLoader.cpp:273 > + Do we still need this? Created attachment 241130 [details]
Fix style issue.
(In reply to comment #4) > Comment on attachment 241129 [details] > Remove iOS specific lines in ResourceLoader.cpp since they are not needed > any more. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=241129&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=138473 > > Add the radar number here. > > > Source/WebCore/loader/ResourceLoader.cpp:273 > > + > > Do we still need this? I think so. There is still WebKit1 clients using identifierForInitialRequest callback and they could stop the resource loading in the callback. Comment on attachment 241130 [details] Fix style issue. Clearing flags on attachment: 241130 Committed r175718: <http://trac.webkit.org/changeset/175718> All reviewed patches have been landed. Closing bug. |