Bug 138472

Summary: Preview views often misplaced inside popover
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, conrad_shultz, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Beth Dakin
Reported 2014-11-06 12:50:45 PST
Preview views often misplaced inside popover
Attachments
Patch (9.21 KB, patch)
2014-11-06 12:54 PST, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2014-11-06 12:54:03 PST
Created attachment 241126 [details] Patch
Beth Dakin
Comment 2 2014-11-06 12:57:09 PST
rdar://problem/18898712
Tim Horton
Comment 3 2014-11-06 12:57:55 PST
Comment on attachment 241126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241126&action=review > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:366 > + return maxHortizontalTargetSizePreservingAspectRatio; horizontal is spelled wrong here.
Anders Carlsson
Comment 4 2014-11-06 12:59:06 PST
> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:328 > +- (BOOL)_targetSize:(NSSize)targetSize fitsInAvailableSpace:(NSSize)availableSpace > +{ > + return targetSize.width <= availableSpace.width && targetSize.height <= availableSpace.height; > +} I think this should just be a static C function bool targetSizeFitsInAvailableSpace(NSSize targetSize, NSSize availableSpace) { } > Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:359 > + FloatRect maxHortizontalTargetSizePreservingAspectRatioRect = largestRectWithAspectRatioInsideRect(aspectRatio, FloatRect(0, 0, maxSpaceAvailableOnXEdge.width, maxSpaceAvailableOnXEdge.height)); Hortizontal! (Tim Hortizontal)
Beth Dakin
Comment 5 2014-11-06 13:03:55 PST
http://trac.webkit.org/changeset/175710
Note You need to log in before you can comment on or make changes to this bug.