Bug 138465

Summary: [EFL] Require at least EFL 1.9 if ENABLE(ACCESSIBILITY) after r175098
Product: WebKit Reporter: Éva Balázsfalvi <evab.u-szeged>
Component: Tools / TestsAssignee: Éva Balázsfalvi <evab.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, k.czech, rakuco, ryuan.choi, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Éva Balázsfalvi
Reported 2014-11-06 07:24:45 PST
After https://trac.webkit.org/changeset/175098 build-webkit fails with EFL 1.7 with the following error: ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp: In member function 'Eina_Bool WebKit::WebAccessibility::action(Ecore_X_Event_Client_Message*)': ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:77:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_OVER' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:86:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_UP' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:89:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_DOWN' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:92:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_SCROLL' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:95:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_MOUSE' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:98:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_ENABLE' was not declared in this scope ../../Source/WebKit2/UIProcess/API/efl/WebAccessibility.cpp:101:28: error: 'ECORE_X_ATOM_E_ILLUME_ACCESS_ACTION_DISABLE' was not declared in this scope These defines introduced in EFL 1.9, so we should require at least EFL 1.9 if ENABLE(ACCESSIBILITY).
Attachments
Patch (1.61 KB, patch)
2014-11-06 07:29 PST, Éva Balázsfalvi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Éva Balázsfalvi
Comment 1 2014-11-06 07:29:33 PST
Created attachment 241105 [details] Patch
Gyuyoung Kim
Comment 2 2014-11-06 18:22:34 PST
Comment on attachment 241105 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2014-11-07 02:07:13 PST
Comment on attachment 241105 [details] Patch Clearing flags on attachment: 241105 Committed r175746: <http://trac.webkit.org/changeset/175746>
WebKit Commit Bot
Comment 4 2014-11-07 02:07:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.