Bug 138458 – TextIndicatorWindow's bounce animation is lopsided when indicating two short lines of text

• Component: New Bugs
• Status: RESOLVED FIXED

[Tim Horton]

TextIndicatorWindow's bounce animation is lopsided when indicating two short lines of text

[Tim Horton]

Created attachment 241095 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/18892496>

[Simon Fraser (smfr)]

Comment on attachment 241095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241095&action=review

> Source/WebKit2/Shared/TextIndicator.cpp:184
> +    for (const FloatRect& textRectInWindowCoordinates : textRectsInWindowCoordinates) {

auto? :\

I would be OK calling textRectInWindowCoordinates "rect".

> Source/WebKit2/Shared/TextIndicator.cpp:185
> +        FloatRect textRectInBoundingRectCoordinates = textRectInWindowCoordinates;

Why didn't you just get it by value?

> Source/WebKit2/Shared/TextIndicator.cpp:268
> +    for (size_t i = 0; i < m_data.textRectsInBoundingRectCoordinates.size(); ++i) {

Modern loop?

> Source/WebKit2/Shared/TextIndicator.cpp:322
> +            FloatRect imageRect = textRect;
> +            imageRect.move(m_data.textBoundingRectInWindowCoordinates.location() - m_data.selectionRectInWindowCoordinates.location());
> +            m_data.contentImage->paint(graphicsContext, m_data.contentImageScaleFactor, enclosingIntRect(textRect).location(), enclosingIntRect(imageRect));

I see this twice. Maybe use a helper function?

[Tim Horton]

http://trac.webkit.org/changeset/175705