Bug 138449

Summary: Revert r175441 as it seems to be causing intermittent crashes in DOMTimer
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 138262    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-05 18:19:44 PST
Revert r175441 as it seems to be causing Intermittent crashes in DOMTimer: ASSERT(scriptExecutionContext()) is hit. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000119d5934a WTFCrash + 42 1 com.apple.WebCore 0x000000011b9a67e1 WebCore::DOMTimer::intervalClampedToMinimum() const + 97 (DOMTimer.cpp:333) 2 com.apple.WebCore 0x000000011b9a7013 WebCore::DOMTimer::updateTimerIntervalIfNecessary() + 99 (DOMTimer.cpp:319) 3 com.apple.WebCore 0x000000011b9a6f9c WebCore::DOMTimer::updateThrottlingStateIfNecessary(WebCore::DOMTimerFireState const&) + 140 (DOMTimer.cpp:204) 4 com.apple.WebCore 0x000000011b9a7528 WebCore::DOMTimer::fired() + 968 (DOMTimer.cpp:301) 5 com.apple.WebCore 0x000000011d1ca07c WebCore::ThreadTimers::sharedTimerFiredInternal() + 396 (ThreadTimers.cpp:135) 6 com.apple.WebCore 0x000000011d1c9d39 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:108) 7 com.apple.WebCore 0x000000011ce8da4f WebCore::timerFired(__CFRunLoopTimer*, void*) + 31 (SharedTimerMac.mm:125) 8 com.apple.CoreFoundation 0x00007fff8eb54b44 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 9 com.apple.CoreFoundation 0x00007fff8eb547d3 __CFRunLoopDoTimer + 1059 10 com.apple.CoreFoundation 0x00007fff8ebc7d9d __CFRunLoopDoTimers + 301 11 com.apple.CoreFoundation 0x00007fff8eb11268 __CFRunLoopRun + 2024 12 com.apple.CoreFoundation 0x00007fff8eb10838 CFRunLoopRunSpecific + 296 13 com.apple.HIToolbox 0x00007fff8a0b03ff RunCurrentEventLoopInMode + 235 14 com.apple.HIToolbox 0x00007fff8a0b017a ReceiveNextEventCommon + 431 15 com.apple.HIToolbox 0x00007fff8a0affbb _BlockUntilNextEventMatchingListInModeWithFilter + 71 16 com.apple.AppKit 0x00007fff85f4b85d _DPSNextEvent + 964 17 com.apple.AppKit 0x00007fff85f4b010 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 194 18 com.apple.AppKit 0x00007fff85f3ef93 -[NSApplication run] + 594 19 com.apple.AppKit 0x00007fff85f2a444 NSApplicationMain + 1832 20 libxpc.dylib 0x00007fff9167fef2 _xpc_objc_main + 793 21 libxpc.dylib 0x00007fff91681a9d xpc_main + 490 22 com.apple.WebKit.WebContent.Development 0x000000010f9ec115 main + 37
Attachments
Patch (3.52 KB, patch)
2014-11-05 18:25 PST, Chris Dumez
no flags
Patch (3.46 KB, patch)
2014-11-05 18:27 PST, Chris Dumez
no flags
Chris Dumez
Comment 1 2014-11-05 18:25:07 PST
Chris Dumez
Comment 2 2014-11-05 18:27:06 PST
Chris Dumez
Comment 3 2014-11-05 18:37:39 PST
Note You need to log in before you can comment on or make changes to this bug.