Bug 138448

Summary: Avoid backing store for opacity:0 descendant layers
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140477    
Attachments:
Description Flags
Patch dino: review+

Simon Fraser (smfr)
Reported 2014-11-05 18:06:46 PST
Avoid backing store for opacity:0 descendant layers
Attachments
Patch (9.57 KB, patch)
2014-11-05 18:08 PST, Simon Fraser (smfr) 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-11-05 18:08:35 PST
Created attachment 241079 [details] Patch
Dean Jackson
Comment 2 2014-11-05 18:14:59 PST
Comment on attachment 241079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241079&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:885 > + if (!oldStyle.opacity() != !newStyle.opacity()) { This is confuserating, but it makes sense after I thought about it for a while. > LayoutTests/compositing/backing/toggle-opacity-0-child-expected.txt:1 > +FAIL: Timed out waiting for notifyDone to be called WAT > LayoutTests/compositing/backing/toggle-opacity-0-child.html:74 > + <div id="child" class="child box"> child is both id and class. you could have used querySelector instead of getElementById
Simon Fraser (smfr)
Comment 3 2014-11-05 18:22:16 PST
https://trac.webkit.org/r175656 rdar://problem/18869336
Note You need to log in before you can comment on or make changes to this bug.