Summary: | Assertion hit DOMTimer::updateTimerIntervalIfNecessary() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, benjamin, cmarcelo, commit-queue, darin, ggaren | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2014-11-05 14:44:30 PST
Created attachment 241069 [details]
Patch
Removing InRadar keyword as it is a separate issue from <rdar://problem/18883681>. Comment on attachment 241069 [details]
Patch
r=me
Comment on attachment 241069 [details] Patch Clearing flags on attachment: 241069 Committed r175655: <http://trac.webkit.org/changeset/175655> All reviewed patches have been landed. Closing bug. The "within epsilon" check only does something useful for values that are close enough to 0. It’s not generally a correct technique to use on arbitrary floating point values. It would be nice to rid our code of this technique if we can find a better solution to these problems in the future. (In reply to comment #6) > The "within epsilon" check only does something useful for values that are > close enough to 0. It’s not generally a correct technique to use on > arbitrary floating point values. > > It would be nice to rid our code of this technique if we can find a better > solution to these problems in the future. Yes, agreed. I can update the function to use one of Knuth's formulas from: http://www.boost.org/doc/libs/1_34_0/libs/test/doc/components/test_tools/floating_point_comparison.html#Introduction I am not sure which formula would be best here but any of those would likely be better than the basic withinEpsilon() check we currently have. Any thought on this? |