Bug 138434

Summary: Web Inspector: support adding and removing timelines to the timeline sidebar panel and overview
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, madonnk, syoichi, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 136292    
Attachments:
Description Flags
Mock Up
none
dynamically adding timelines
none
Patch (needs rebase)
none
Proposed Fix timothy: review+

Description Brian Burg 2014-11-05 12:57:47 PST 
This will support workflows where the user can add new profiling "instruments".
Comment 1 Radar WebKit Bug Importer 2014-11-05 12:57:58 PST 
<rdar://problem/18884799>
Comment 2 Timothy Hatcher 2014-11-05 13:40:01 PST 
Created attachment 241053 [details]
Mock Up

Here is a mock up on what I thought at the time I was designing the new Timelines view.
Comment 3 Brian Burg 2015-02-07 23:57:19 PST 
Created attachment 246234 [details]
dynamically adding timelines

I have written a patch to dynamically add/remove timelines, and will upload soon. If you want to change the UI (adding opt-in checkboxes, etc0, that can go in a different bug.
Comment 4 Brian Burg 2015-02-08 00:46:02 PST 
Created attachment 246237 [details]
Patch (needs rebase)
Comment 5 Brian Burg 2015-02-08 00:55:54 PST 
Created attachment 246239 [details]
Proposed Fix
Comment 6 Timothy Hatcher 2015-02-12 10:22:39 PST 
Comment on attachment 246239 [details]
Proposed Fix

Really nice!
Comment 7 Brian Burg 2015-02-12 11:00:09 PST 
Committed r180001: <http://trac.webkit.org/changeset/180001>