Bug 138419

Summary: [EFL] Remove m_scrollPosition from CoordinatedGraphicsScene
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, gyuyoung.kim, lucas.de.marchi, luiz, noam, rniwa, sergio, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ryuan Choi 2014-11-05 06:14:05 PST 
m_scrollPosition of CoordinatedGraphicsScene is only to adjust fixed element in paintToCurrentGLContext.
But, WebView already know it so we can pass it to paintToCurrentGLContext.
Comment 1 Ryuan Choi 2014-11-05 06:20:12 PST 
Created attachment 241025 [details]
Patch
Comment 2 Gyuyoung Kim 2014-11-06 00:16:25 PST 
Comment on attachment 241025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241025&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:-77
> -    const FloatPoint& scrollPosition = rect.location();

Is this scrollPosition same with contentPosition which is used by this patch ? I think this patch should pass WKViewRestoreZoomAndScrollBackForward unit test at least.
Comment 3 Ryuan Choi 2014-11-06 00:26:34 PST 
Comment on attachment 241025 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241025&action=review

>> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:-77
>> -    const FloatPoint& scrollPosition = rect.location();
> 
> Is this scrollPosition same with contentPosition which is used by this patch ? I think this patch should pass WKViewRestoreZoomAndScrollBackForward unit test at least.

Sure, scroll API such as EwkView::scrollBy update m_contentPosition via WKViewSetContentPosition and calls setVisibleContentRect via didChangeContentsVisibility.
If these are different, fixed elements will be drawn at wrong coordination.

And I tested WKViewRestoreZoomAndScrollBackForward and WKViewScrollTo and both tests are fine.
Comment 4 WebKit Commit Bot 2014-11-06 02:08:53 PST 
Comment on attachment 241025 [details]
Patch

Clearing flags on attachment: 241025

Committed r175692: <http://trac.webkit.org/changeset/175692>
Comment 5 WebKit Commit Bot 2014-11-06 02:09:00 PST 
All reviewed patches have been landed.  Closing bug.