Bug 138382

Summary:

Disable failing v8-deltablue.js for ARM

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

Attachments:

Description	Flags
Patch	none

Michael Saboff

Reported 2014-11-04 15:55:13 PST

This test is flakey when run on ARM on iOS. This test will be disabled, fixed and then re-enabled. It dies with the following output: [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: Exception: TypeError: undefined is not a function (evaluating 'this.v2.addConstraint(this)') [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addToGraph@v8-deltablue.js:377:24 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addToGraph@v8-deltablue.js:462:61 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addConstraint@v8-deltablue.js:155:18 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: BinaryConstraint@v8-deltablue.js:340:21 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: ScaleConstraint@v8-deltablue.js:453:40 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: projectionTest@v8-deltablue.js:837:24 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: deltaBlue@v8-deltablue.js:873:17 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: global code@v8-deltablue.js:877:14 [2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: ERROR: Unexpected exit code: 3

Attachments
Patch (1.11 KB, patch) 2014-11-04 16:01 PST, Michael Saboff	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2014-11-04 15:57:19 PST

This test actually fails all the time.

Michael Saboff

Comment 2 2014-11-04 16:01:08 PST

Created attachment 240972 [details] Patch

Geoffrey Garen

Comment 3 2014-11-04 16:03:39 PST

This seems like a much more serious failure than what you described to me earlier today. You should put this in Radar as a P1.

Geoffrey Garen

Comment 4 2014-11-04 16:04:13 PST

Comment on attachment 240972 [details] Patch r=me if you put this in Radar as a P1 before skipping the test.

Michael Saboff

Comment 5 2014-11-04 16:13:52 PST

(In reply to comment #4) > Comment on attachment 240972 [details] > Patch > > r=me if you put this in Radar as a P1 before skipping the test. <rdar://problem/18874091> It is now a P1.

WebKit Commit Bot

Comment 6 2014-11-04 16:53:55 PST

Comment on attachment 240972 [details] Patch Clearing flags on attachment: 240972 Committed r175590: <http://trac.webkit.org/changeset/175590>

WebKit Commit Bot

Comment 7 2014-11-04 16:53:58 PST

All reviewed patches have been landed. Closing bug.

Michael Saboff

Comment 8 2014-11-04 17:28:53 PST

Bug to fix the tests is <https://bugs.webkit.org/show_bug.cgi?id=138392> - "Fix failing v8-deltablue.js for ARM"

Note You need to log in before you can comment on or make changes to this bug.