Bug 138382

Summary:

Disable failing v8-deltablue.js for ARM

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

Attachments:

Description	Flags
Patch	none

Description Michael Saboff 2014-11-04 15:55:13 PST

This test is flakey when run on ARM on iOS.  This test will be disabled, fixed and then re-enabled.  It dies with the following output:

[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: Exception: TypeError: undefined is not a function (evaluating 'this.v2.addConstraint(this)')
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addToGraph@v8-deltablue.js:377:24
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addToGraph@v8-deltablue.js:462:61
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: addConstraint@v8-deltablue.js:155:18
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: BinaryConstraint@v8-deltablue.js:340:21
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: ScaleConstraint@v8-deltablue.js:453:40
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: projectionTest@v8-deltablue.js:837:24
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: deltaBlue@v8-deltablue.js:873:17
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: global code@v8-deltablue.js:877:14
[2014-11-04 13:42:12] INFO: v8-v6/v8-deltablue.js.dfg-eager-no-cjit-validate: ERROR: Unexpected exit code: 3

Comment 1 Michael Saboff 2014-11-04 15:57:19 PST

This test actually fails all the time.

Comment 2 Michael Saboff 2014-11-04 16:01:08 PST

Created attachment 240972 [details]
Patch

Comment 3 Geoffrey Garen 2014-11-04 16:03:39 PST

This seems like a much more serious failure than what you described to me earlier today. You should put this in Radar as a P1.

Comment 4 Geoffrey Garen 2014-11-04 16:04:13 PST

Comment on attachment 240972 [details]
Patch

r=me if you put this in Radar as a P1 before skipping the test.

Comment 5 Michael Saboff 2014-11-04 16:13:52 PST

(In reply to comment #4)
> Comment on attachment 240972 [details]
> Patch
> 
> r=me if you put this in Radar as a P1 before skipping the test.

<rdar://problem/18874091>

It is now a P1.

Comment 6 WebKit Commit Bot 2014-11-04 16:53:55 PST

Comment on attachment 240972 [details]
Patch

Clearing flags on attachment: 240972

Committed r175590: <http://trac.webkit.org/changeset/175590>

Comment 7 WebKit Commit Bot 2014-11-04 16:53:58 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 Michael Saboff 2014-11-04 17:28:53 PST

Bug to fix the tests is <https://bugs.webkit.org/show_bug.cgi?id=138392> - "Fix failing v8-deltablue.js for ARM"