Bug 138331

Summary: Allow implicit conversion from Ref<T> to T&
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, commit-queue, darin, kling, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-11-03 15:59:28 PST
Allow implicit conversion from Ref<T> to T& to reduce the amount of Ref<>::get() calls in the code and increase readability. Unlike for RefPtr, doing this for Ref should not be error prone.
Attachments
Patch (37.08 KB, patch)
2014-11-03 16:09 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (40.03 KB, patch)
2014-11-03 21:23 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-11-03 16:09:12 PST
Created attachment 240880 [details] Patch
Andreas Kling
Comment 2 2014-11-03 18:28:45 PST
I kinda like this. Paging Darin for 2nd opinion.
Darin Adler
Comment 3 2014-11-03 18:43:56 PST
I like it too. Unless we have to get rid of Ref completely.
Chris Dumez
Comment 4 2014-11-03 21:23:42 PST
Created attachment 240910 [details] Patch
Andreas Kling
Comment 5 2014-11-03 22:42:38 PST
(In reply to comment #3) > I like it too. Unless we have to get rid of Ref completely. We do? Let's find time to discuss that in person at some point.
Andreas Kling
Comment 6 2014-11-03 22:42:51 PST
Comment on attachment 240910 [details] Patch r=me on this.
WebKit Commit Bot
Comment 7 2014-11-03 23:22:13 PST
Comment on attachment 240910 [details] Patch Clearing flags on attachment: 240910 Committed r175513: <http://trac.webkit.org/changeset/175513>
WebKit Commit Bot
Comment 8 2014-11-03 23:22:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.