Bug 138302

Summary: Rename FindIndicator{Window} to TextIndicator{Window}
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, mitz, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
rename andersca: review+

Tim Horton
Reported 2014-11-03 01:02:50 PST
Rename FindIndicator{Window} to TextIndicator{Window} (and related), because it will soon be used to indicate ranges of text that are not necessarily find-in-page results.
Attachments
rename (79.88 KB, patch)
2014-11-03 01:03 PST, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-03 01:03:15 PST
Created attachment 240833 [details] rename
Tim Horton
Comment 2 2014-11-03 01:03:41 PST
I'm open to better name suggestions.
WebKit Commit Bot
Comment 3 2014-11-03 01:05:19 PST
Attachment 240833 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Radar WebKit Bug Importer
Comment 4 2014-11-03 11:13:54 PST
<rdar://problem/18855190>
Tim Horton
Comment 5 2014-11-03 11:17:35 PST
http://trac.webkit.org/changeset/175476
Note You need to log in before you can comment on or make changes to this bug.