Bug 138300

Summary: Use FrameSnapshotting functions in FindController::getFindIndicatorBitmap
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Tim Horton
Reported 2014-11-03 00:13:39 PST
Created attachment 240831 [details] patch FindController::getFindIndicatorBitmapAndRect has a lot of overlap with WebCore FrameSnapshotting functions.
Attachments
patch (9.50 KB, patch)
2014-11-03 00:13 PST, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-11-03 00:14:17 PST
Not sure if the extra paint is acceptable, but I haven't quite worked out how to get rid of it without making FrameSnapshotting uglier.
WebKit Commit Bot
Comment 2 2014-11-03 00:17:03 PST
Attachment 240831 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-11-03 09:00:49 PST
Comment on attachment 240831 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=240831&action=review > Source/WebKit2/WebProcess/WebPage/FindController.cpp:264 > + auto snapshot = snapshotSelection(frame, WebCore::SnapshotOptionsForceBlackText); Don't like auto here.
Radar WebKit Bug Importer
Comment 4 2014-11-03 11:45:54 PST
<rdar://problem/18855863>
Tim Horton
Comment 5 2014-11-03 12:09:21 PST
http://trac.webkit.org/changeset/175484
Note You need to log in before you can comment on or make changes to this bug.