Bug 138294

Summary: Video controls have lots of compositing layers
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, dino, eric.carlson, glenn, jer.noble, jonlee, philipj, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Layer borders screenshot
none
Patch none

Simon Fraser (smfr)
Reported 2014-11-02 10:57:02 PST
Created attachment 240816 [details] Layer borders screenshot The video controls have a separate compositing layer for each button. I think we lost a z-index that we used to have.
Attachments
Layer borders screenshot (12.86 KB, image/png)
2014-11-02 10:57 PST, Simon Fraser (smfr) 		no flags
Details
Patch (1.53 KB, patch)
2014-11-03 14:10 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-11-02 10:57:42 PST
Should we do this? diff --git a/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css b/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css index 2db40b85f91d76ff8ed21329d9b3b1605452ac3d..b311524148cce41fe39102c191933ec1d627b009 100644 --- a/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css +++ b/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css @@ -68,6 +68,7 @@ video::-webkit-media-controls-panel, audio::-webkit-media-controls-panel { box-sizing: border-box; position: relative; + z-index: 0; bottom: 0; width: 100%; padding-top: 1px;
Simon Fraser (smfr)
Comment 2 2014-11-02 11:06:13 PST
This seems to be a recent regression, probably from http://trac.webkit.org/changeset/175268
Simon Fraser (smfr)
Comment 3 2014-11-03 14:10:01 PST
Created attachment 240875 [details] Patch
WebKit Commit Bot
Comment 4 2014-11-03 14:54:31 PST
Comment on attachment 240875 [details] Patch Clearing flags on attachment: 240875 Committed r175492: <http://trac.webkit.org/changeset/175492>
WebKit Commit Bot
Comment 5 2014-11-03 14:54:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2014-11-07 15:06:02 PST
<rdar://problem/18914116>
Note You need to log in before you can comment on or make changes to this bug.