Summary: | x/y values on rootmost <svg> elements should be ignored | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <ml> | ||||||||
Component: | SVG | Assignee: | Oliver Hunt <oliver> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 523.x (Safari 3) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
Attachments: |
|
Description
Antoine Quint
2007-05-22 13:45:12 PDT
Created attachment 14664 [details]
Test case for x/y attributes on root-most <svg> element
For the test to pass, the green SVG square should be rendered aligned to the top-left of the red CSS-rendered square, which is 10 pixels wider and taller.
Created attachment 14724 [details]
First attempt
Not that happy with the checks, but I think it is the safest way.
Cheers,
Rob.
Comment on attachment 14724 [details]
First attempt
i find myself wondering whether
else {
+ rootX += x().value();
+ rootY += y().value();
}
should account for tx, ty
though the more i think about the less i think it should.. hmmm...
also the += can just be + now
fianlly, the layout test in this case can *probably* be text only... eg. eventController.dumpAsText
or somthing
Comment on attachment 14724 [details]
First attempt
R=me, following discussion on irc
pixel test is necessary as screenctm and layout/painting follow completely different paths
svg/custom/rootmost-svg-xy-attrs seems to be failing on feature branch. Perhaps this patch was forgotten during the merge? Created attachment 16510 [details]
new fix for feature-branch
|