Bug 138278

Summary: REGRESSION: Using a media element changes window.name
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: MediaAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, jer.noble, joepeck, ltilve, philipj, sergio
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
jer.noble: review+
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Alexey Proskuryakov
Reported 2014-10-31 23:56:54 PDT
Having an audio element in a page magically changes page name to "webkitendfullscreen". rdar://problem/18704134
Attachments
proposed fix (4.34 KB, patch)
2014-11-01 00:04 PDT, Alexey Proskuryakov 		jer.noble: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (601.73 KB, application/zip)
2014-11-01 00:37 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (491.79 KB, application/zip)
2014-11-01 01:08 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-11-01 00:04:40 PDT
Created attachment 240784 [details] proposed fix
Build Bot
Comment 2 2014-11-01 00:37:54 PDT
Created attachment 240785 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 3 2014-11-01 01:08:32 PDT
Created attachment 240786 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Alexey Proskuryakov
Comment 4 2014-11-02 00:01:04 PDT
Committed <http://trac.webkit.org/r175460>. The test that EWS complained about had incorrect Mac-specific results, which are unneeded now, as we just match cross-platform results.
Joseph Pecoraro
Comment 5 2014-11-03 10:20:42 PST
Comment on attachment 240784 [details] proposed fix Can you also make these changes to mediaControlsBase.js? It looks like it is missing the exact same "var"s.
Alexey Proskuryakov
Comment 6 2014-11-03 11:21:28 PST
OK, landed in r175477. But who uses this file? It's not part of Xcode project.
Joseph Pecoraro
Comment 7 2014-11-03 11:27:01 PST
(In reply to comment #6) > OK, landed in r175477. But who uses this file? It's not part of Xcode > project. Seemingly the Linux ports: shell> ack mediaControlsBase.js PlatformEfl.cmake 283: ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsBase.js PlatformGTK.cmake 261: ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsBase.js
Lorenzo Tilve
Comment 8 2014-11-03 11:38:05 PST
I had created a patch for MediaControlsBase.js based on these changes, as the test was failing on GTK and EFL, on this bug https://bugs.webkit.org/show_bug.cgi?id=138319 (as this one had been closed).
Lorenzo Tilve
Comment 9 2014-11-03 11:44:01 PST
> I had created a patch for MediaControlsBase.js based on these changes, as > the test was failing on GTK and EFL, on this bug > https://bugs.webkit.org/show_bug.cgi?id=138319 (as this one had been closed). Ok. I see that those changes have been now also landed, so closing the bug.
Lorenzo Tilve
Comment 10 2014-11-03 11:46:16 PST
*** Bug 138319 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.