| Summary: | REGRESSION: Using a media element changes window.name | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
| Component: | Media | Assignee: | Alexey Proskuryakov <ap> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, glenn, jer.noble, joepeck, ltilve, philipj, sergio | ||||||||
| Priority: | P2 | Keywords: | InRadar, Regression | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alexey Proskuryakov
2014-10-31 23:56:54 PDT
Created attachment 240784 [details]
proposed fix
Created attachment 240785 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 240786 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Committed <http://trac.webkit.org/r175460>. The test that EWS complained about had incorrect Mac-specific results, which are unneeded now, as we just match cross-platform results. Comment on attachment 240784 [details]
proposed fix
Can you also make these changes to mediaControlsBase.js? It looks like it is missing the exact same "var"s.
OK, landed in r175477. But who uses this file? It's not part of Xcode project. (In reply to comment #6) > OK, landed in r175477. But who uses this file? It's not part of Xcode > project. Seemingly the Linux ports: shell> ack mediaControlsBase.js PlatformEfl.cmake 283: ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsBase.js PlatformGTK.cmake 261: ${WEBCORE_DIR}/Modules/mediacontrols/mediaControlsBase.js I had created a patch for MediaControlsBase.js based on these changes, as the test was failing on GTK and EFL, on this bug https://bugs.webkit.org/show_bug.cgi?id=138319 (as this one had been closed). > I had created a patch for MediaControlsBase.js based on these changes, as
> the test was failing on GTK and EFL, on this bug
> https://bugs.webkit.org/show_bug.cgi?id=138319 (as this one had been closed).
Ok. I see that those changes have been now also landed, so closing the bug.
*** Bug 138319 has been marked as a duplicate of this bug. *** |