Bug 138277

Summary: [Cocoa] Darwin vouchers aren’t carried over IPC::Connection and WTF::RunLoop dispatch
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: andersca, ap, benjamin, cmarcelo, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Something for the bots
none
Something else for the bots none

mitz
Reported 2014-10-31 22:30:34 PDT
When work is dispatched to another process or run loop, the associated voucher isn’t carried along.
Attachments
Something for the bots (9.33 KB, patch)
2014-10-31 22:31 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Something else for the bots (9.43 KB, patch)
2014-10-31 23:27 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-10-31 22:31:15 PDT
Created attachment 240781 [details] Something for the bots
WebKit Commit Bot
Comment 2 2014-10-31 22:34:20 PDT
Attachment 240781 [details] did not pass style-queue: ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:36: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:39: Extra space before [ [whitespace/braces] [5] ERROR: Source/WTF/wtf/FunctionDispatcher.cpp:40: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/FunctionDispatcher.h:46: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/FunctionDispatcher.h:46: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-10-31 23:27:05 PDT
Created attachment 240783 [details] Something else for the bots
WebKit Commit Bot
Comment 4 2014-10-31 23:29:09 PDT
Attachment 240783 [details] did not pass style-queue: ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:36: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:39: Extra space before [ [whitespace/braces] [5] ERROR: Source/WTF/wtf/FunctionDispatcher.cpp:40: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/FunctionDispatcher.h:46: The parameter name "function" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/FunctionDispatcher.h:46: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.