Bug 138277

Summary:

[Cocoa] Darwin vouchers aren’t carried over IPC::Connection and WTF::RunLoop dispatch

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

andersca, ap, benjamin, cmarcelo, commit-queue, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Something for the bots	none
Something else for the bots	none

Description mitz 2014-10-31 22:30:34 PDT

When work is dispatched to another process or run loop, the associated voucher isn’t carried along.

Comment 1 mitz 2014-10-31 22:31:15 PDT

Created attachment 240781 [details]
Something for the bots

Comment 2 WebKit Commit Bot 2014-10-31 22:34:20 PDT

Attachment 240781 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:36:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:39:  Extra space before [  [whitespace/braces] [5]
ERROR: Source/WTF/wtf/FunctionDispatcher.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:46:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 mitz 2014-10-31 23:27:05 PDT

Created attachment 240783 [details]
Something else for the bots

Comment 4 WebKit Commit Bot 2014-10-31 23:29:09 PDT

Attachment 240783 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:36:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/darwin/FunctionDispatcherDarwin.cpp:39:  Extra space before [  [whitespace/braces] [5]
ERROR: Source/WTF/wtf/FunctionDispatcher.cpp:40:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:46:  The parameter name "function" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WTF/wtf/FunctionDispatcher.h:46:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 5 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.