Bug 138227

Summary: Make CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement() faster
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2014-10-30 13:37:36 PDT
CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement() currently does a lot of if checks, even though some of them are mutually exclusive. We can reduce the amount of checks by using "else ifs" instead of ifs where appropriate.
Attachments
Patch (8.17 KB, patch)
2014-10-30 14:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.20 KB, patch)
2014-10-30 14:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-30 14:24:14 PDT
Created attachment 240699 [details] Patch
Chris Dumez
Comment 2 2014-10-30 14:38:58 PDT
Created attachment 240703 [details] Patch
WebKit Commit Bot
Comment 3 2014-10-31 14:43:30 PDT
Comment on attachment 240703 [details] Patch Clearing flags on attachment: 240703 Committed r175427: <http://trac.webkit.org/changeset/175427>
WebKit Commit Bot
Comment 4 2014-10-31 14:43:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.