Bug 138202

Summary: Optimize HTMLVideoElement / HTMLAudioElement type checks a bit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138322    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2014-10-29 17:46:22 PDT
Optimize HTMLVideoElement / HTMLAudioElement type checks a bit by: 1. using is<HTMLMediaElement>() instead of is<HTMLVideoElement>() || is<HTMLAudioElement>() if the caller is interested in both video and audio elements 2. Updating HTMLVideoElement / HTMLAudioElement type traits specialization to avoid doing an isHTMLUnknownElement() check if the input type is an HTMLMediaElement (which is common in the code base)
Attachments
Patch (8.09 KB, patch)
2014-10-29 19:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2014-10-29 20:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.88 KB, patch)
2014-10-29 20:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-29 19:54:16 PDT
Created attachment 240651 [details] Patch
Chris Dumez
Comment 2 2014-10-29 20:02:10 PDT
Created attachment 240652 [details] Patch
Chris Dumez
Comment 3 2014-10-29 20:07:23 PDT
Created attachment 240653 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-30 14:25:32 PDT
Comment on attachment 240653 [details] Patch Clearing flags on attachment: 240653 Committed r175380: <http://trac.webkit.org/changeset/175380>
WebKit Commit Bot
Comment 5 2014-10-30 14:25:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.