Bug 138202

Summary: Optimize HTMLVideoElement / HTMLAudioElement type checks a bit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, commit-queue, darin, kling, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138322    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2014-10-29 17:46:22 PDT 
Optimize HTMLVideoElement / HTMLAudioElement type checks a bit by:
1. using is<HTMLMediaElement>() instead of is<HTMLVideoElement>() || is<HTMLAudioElement>() if the caller is interested in both video and audio elements
2. Updating HTMLVideoElement / HTMLAudioElement type traits specialization to avoid doing an isHTMLUnknownElement() check if the input type is an HTMLMediaElement (which is common in the code base)
Comment 1 Chris Dumez 2014-10-29 19:54:16 PDT 
Created attachment 240651 [details]
Patch
Comment 2 Chris Dumez 2014-10-29 20:02:10 PDT 
Created attachment 240652 [details]
Patch
Comment 3 Chris Dumez 2014-10-29 20:07:23 PDT 
Created attachment 240653 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-30 14:25:32 PDT 
Comment on attachment 240653 [details]
Patch

Clearing flags on attachment: 240653

Committed r175380: <http://trac.webkit.org/changeset/175380>
Comment 5 WebKit Commit Bot 2014-10-30 14:25:36 PDT 
All reviewed patches have been landed.  Closing bug.