Bug 138191

Summary: Use plain JSArray for RegExp matches instead of a lazily populated custom object.
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ggaren, msaboff, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2014-10-29 15:30:19 PDT 
We're already offering two RegExp matching APIs, one that collects subpattern
matches (exec), and one that simply tests for a match (test).
Given that, it was pretty overkill to lazily populate the resulting array of
matches, since the user could simply use test() if they didn't need them.
Comment 1 Andreas Kling 2014-10-29 15:36:25 PDT 
Created attachment 240633 [details]
Patch
Comment 2 Geoffrey Garen 2014-10-29 17:18:36 PDT 
Comment on attachment 240633 [details]
Patch

Bokay.
Comment 3 WebKit Commit Bot 2014-10-29 20:54:21 PDT 
Comment on attachment 240633 [details]
Patch

Clearing flags on attachment: 240633

Committed r175365: <http://trac.webkit.org/changeset/175365>
Comment 4 WebKit Commit Bot 2014-10-29 20:54:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2014-10-30 05:09:53 PDT 
(In reply to comment #3)
> Comment on attachment 240633 [details]
> Patch
> 
> Clearing flags on attachment: 240633
> 
> Committed r175365: <http://trac.webkit.org/changeset/175365>

It made 41 JSC test fail on Apple's debug bots. (32 and 64 bit too)