Bug 138157

Summary:

All networking crashes on Mac 32bit

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, ap, darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aestes: review+

Description Geoffrey Garen 2014-10-28 16:42:43 PDT

All networking crashes on 32bit

Comment 1 Geoffrey Garen 2014-10-28 16:43:55 PDT

Created attachment 240577 [details]
Patch

Comment 2 Andy Estes 2014-10-28 16:48:14 PDT

Comment on attachment 240577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240577&action=review

Whoops. r=me.

> Source/WebCore/ChangeLog:8
> +        Content filtering is not available on 32bit, so soft-linking fails at

NEFilterSource content filtering, that is.

Comment 3 Geoffrey Garen 2014-10-28 16:50:30 PDT

Committed r175283: <http://trac.webkit.org/changeset/175283>

Comment 4 Darin Adler 2014-10-28 17:26:20 PDT

Was this a recent regression?

Comment 5 Andy Estes 2014-10-28 17:51:46 PDT

(In reply to comment #4)
> Was this a recent regression?

I don't think so. I believe this bug existed since I implemented NEFilterSource. It didn't occur to me that the framework would be 64-bit only.

Comment 6 Andy Estes 2014-10-28 17:54:26 PDT

Is there a radar for this Geoff?

Comment 7 Alexey Proskuryakov 2014-10-28 20:23:05 PDT

I believe that this bug is harmless in release builds.

Comment 8 Alexey Proskuryakov 2014-10-28 20:24:56 PDT

Specifically, what happens is that an assertion fails in soft linking macro, but then we just send a message to a nil receiver.

Comment 9 Geoffrey Garen 2014-10-28 21:58:32 PDT

I didn't file a Radar: I just noticed this while testing bmalloc in 32bit mode.