Bug 138144

Summary: [Cocoa] REGERESSION (r171801): Client certificate authentication is failing
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Encode the individual pieces of identity-based credentials separately ap: review+

Description mitz 2014-10-28 12:51:23 PDT
<http://trac.webkit.org/r171801> broke client certificate authentication, because NSURLCredential doesn’t serialize identities properly. Patch forthcoming.
Comment 1 mitz 2014-10-28 12:57:52 PDT
Created attachment 240564 [details]
Encode the individual pieces of identity-based credentials separately
Comment 2 Alexey Proskuryakov 2014-10-28 13:00:23 PDT
Comment on attachment 240564 [details]
Encode the individual pieces of identity-based credentials separately

View in context: https://bugs.webkit.org/attachment.cgi?id=240564&action=review

> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:286
> +    // NSURLCredential doesn't serialize identities correctly, so we encode the pieces individually in the identity case.

Is there a bug tracking a fix for this incorrectness?
Comment 3 mitz 2014-10-28 13:01:57 PDT
Fixed in <http://trac.webkit.org/r175270>.
Comment 4 mitz 2014-10-28 13:03:38 PDT
(In reply to comment #2)
> Comment on attachment 240564 [details]
> Encode the individual pieces of identity-based credentials separately
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240564&action=review
> 
> > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:286
> > +    // NSURLCredential doesn't serialize identities correctly, so we encode the pieces individually in the identity case.
> 
> Is there a bug tracking a fix for this incorrectness?

I don’t know. If there is, it will be in Radar, not in bugs.webkit.org.