Bug 138120 – REGRESSION(r175233): Broke many accessibility tests (Requested by ap on #webkit).

• Component: New Bugs
• Status: RESOLVED INVALID

[WebKit Commit Bot]

http://trac.webkit.org/changeset/175233 broke the build:
Broke many accessibility tests (Requested by ap on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 240521 [details]
ROLLOUT of r175233

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Alexey Proskuryakov]

Actually, it's easier to fix.

[Chris Dumez]

Comment on attachment 240521 [details]
ROLLOUT of r175233

Hmm, interesting. The only difference seems to be if the Element actually has the use map attribute but that attribute is null. AFAIK, this is not supposed to happen. So if this change really caused the test regressions, we should probably try to understand how this happened.

[Chris Dumez]

Comment on attachment 240521 [details]
ROLLOUT of r175233

View in context: https://bugs.webkit.org/attachment.cgi?id=240521&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2457
> +    if (node && is<HTMLImageElement>(*node) && !downcast<HTMLImageElement>(*node).fastGetAttribute(usemapAttr).isNull())

Ah ah, never mind, I missed the extra "!" :)