Bug 138047

Summary:

Replace INT_MIN/MAX / kFixedPointDenominator with intMin/MaxForLayoutUnit.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

zalan

Reported 2014-10-24 11:02:55 PDT

-const int maxValueForCssLength = INT_MAX / kFixedPointDenominator - 2; -const int minValueForCssLength = INT_MIN / kFixedPointDenominator + 2; +const int maxValueForCssLength = intMaxForLayoutUnit - 2; +const int minValueForCssLength = intMinForLayoutUnit + 2;

Attachments
Patch (1.62 KB, patch) 2014-10-24 11:04 PDT, zalan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2014-10-24 11:04:47 PDT

Created attachment 240415 [details] Patch

WebKit Commit Bot

Comment 2 2014-10-24 14:00:01 PDT

Comment on attachment 240415 [details] Patch Clearing flags on attachment: 240415 Committed r175177: <http://trac.webkit.org/changeset/175177>

WebKit Commit Bot

Comment 3 2014-10-24 14:00:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.