|Summary:||[Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()|
|Product:||WebKit||Reporter:||Chris Dumez <cdumez>|
|Component:||WebKit Misc.||Assignee:||Chris Dumez <cdumez>|
|Severity:||Enhancement||CC:||ap, commit-queue, darin|
|Version:||528+ (Nightly build)|
Description Chris Dumez 2014-10-23 21:32:27 PDT
Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks() for case-insensitive string comparison instead of converting to UTF-8 and then using strcasecmp().
Comment 2 Build Bot 2014-10-23 22:25:01 PDT
Created attachment 240392 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment 3 Chris Dumez 2014-10-23 22:33:48 PDT
Hmm, the following layout tests are failing on the bots, so I must have changed the behavior unintentionally: Regressions: Unexpected text-only failures (2) http/tests/cache/loaded-from-cache-after-reload-within-iframe.html [ Failure ] http/tests/cache/post-redirect-get.php [ Failure ]
Comment 4 Chris Dumez 2014-10-23 23:03:46 PDT
Created attachment 240397 [details] Patch Gosh, [NSString caseInsensitiveCompare] returns True if the NSString is nil :)
Comment 5 Darin Adler 2014-10-24 09:17:05 PDT
Comment on attachment 240397 [details] Patch Did you land this already? I would set review+ but it does’t have review?.
Comment 6 Chris Dumez 2014-10-24 10:23:20 PDT
(In reply to comment #5) > Comment on attachment 240397 [details] > Patch > > Did you land this already? I would set review+ but it does’t have review?. I did not land it. Bugzilla just won't let me set the review flag (gives me an error)...
Comment 7 Chris Dumez 2014-10-24 10:37:33 PDT
Bugzilla is partially back and the review flag is set!
Comment 8 Darin Adler 2014-10-24 12:34:12 PDT
Comment on attachment 240397 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240397&action=review > Source/WebCore/platform/mac/QuickLookMac.mm:45 > + if (bundleID && [bundleID caseInsensitiveCompare:@"com.apple.QuickLookUIFramework"] == NSOrderedSame) (Side note: This does a little extra work because it for use in sorting, not just an equality comparison, which is why the WebKit framework has a helper method for this that uses a slightly different method. But here this seems fine.)
Comment 9 WebKit Commit Bot 2014-10-24 13:12:43 PDT
Comment on attachment 240397 [details] Patch Clearing flags on attachment: 240397 Committed r175174: <http://trac.webkit.org/changeset/175174>
Comment 10 WebKit Commit Bot 2014-10-24 13:12:46 PDT
All reviewed patches have been landed. Closing bug.