Bug 138039 – [Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks() for case-insensitive string comparison instead of converting to UTF-8 and then using strcasecmp().

[Chris Dumez]

Created attachment 240391 [details]
Patch

[Build Bot]

Created attachment 240392 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chris Dumez]

Hmm, the following layout tests are failing on the bots, so I must have changed the behavior unintentionally:
Regressions: Unexpected text-only failures (2)
  http/tests/cache/loaded-from-cache-after-reload-within-iframe.html [ Failure ]
  http/tests/cache/post-redirect-get.php [ Failure ]

[Chris Dumez]

Created attachment 240397 [details]
Patch

Gosh, [NSString caseInsensitiveCompare] returns True if the NSString is nil :)

[Darin Adler]

Comment on attachment 240397 [details]
Patch

Did you land this already? I would set review+ but it does’t have review?.

[Chris Dumez]

(In reply to comment #5)
> Comment on attachment 240397 [details]
> Patch
> 
> Did you land this already? I would set review+ but it does’t have review?.

I did not land it. Bugzilla just won't let me set the review flag (gives me an error)...

[Chris Dumez]

Bugzilla is partially back and the review flag is set!

[Darin Adler]

Comment on attachment 240397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240397&action=review

> Source/WebCore/platform/mac/QuickLookMac.mm:45
> +        if (bundleID && [bundleID caseInsensitiveCompare:@"com.apple.QuickLookUIFramework"] == NSOrderedSame)

(Side note: This does a little extra work because it for use in sorting, not just an equality comparison, which is why the WebKit framework has a helper method for this that uses a slightly different method. But here this seems fine.)

[WebKit Commit Bot]

Comment on attachment 240397 [details]
Patch

Clearing flags on attachment: 240397

Committed r175174: <http://trac.webkit.org/changeset/175174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.