Bug 138024

Summary: Get rid of unnecessary vtables in WebKit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2014-10-23 14:59:03 PDT
Get rid of unnecessary vtables in WebKit by de-virtualizing destructors when possible and marking the class as final to make sure people don't subclass it.
Attachments
Patch (11.01 KB, patch)
2014-10-23 15:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2014-10-23 15:01:13 PDT
Created attachment 240370 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-23 16:30:37 PDT
Comment on attachment 240370 [details] Patch Clearing flags on attachment: 240370 Committed r175149: <http://trac.webkit.org/changeset/175149>
WebKit Commit Bot
Comment 3 2014-10-23 16:30:42 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2014-10-23 20:10:18 PDT
Comment on attachment 240370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240370&action=review > Source/WebCore/css/WebKitCSSMatrix.h:39 > +class WebKitCSSMatrix final : public ScriptWrappable, public RefCounted<WebKitCSSMatrix> { We should probably give ScriptWrappable a protected destructor to make it safer.
Chris Dumez
Comment 5 2014-10-23 20:30:21 PDT
(In reply to comment #4) > Comment on attachment 240370 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240370&action=review > > > Source/WebCore/css/WebKitCSSMatrix.h:39 > > +class WebKitCSSMatrix final : public ScriptWrappable, public RefCounted<WebKitCSSMatrix> { > > We should probably give ScriptWrappable a protected destructor to make it > safer. Good idea, I'll follow-up on this.
Note You need to log in before you can comment on or make changes to this bug.