Bug 138022

Summary:	[Win] After removing SafariTheme forms controls differ from Mac a lot
Product:	WebKit	Reporter:	Roger Fong <roger_fong>
Component:	Layout and Rendering	Assignee:	Brent Fulgham <bfulgham>
Status:	NEW ---
Severity:	Normal	CC:	ahmad.saleem792, ap, bfulgham, don.olmstead, Hironori.Fujii, roger_fong
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Roger Fong 2014-10-23 14:33:42 PDT

fast/forms/HTMLOptionElement_label06.html [ Failure ]
  fast/forms/HTMLOptionElement_label07.html [ Failure ]
  fast/forms/basic-inputs.html [ Failure ]
  fast/forms/basic-textareas-quirks.html [ Failure ]
  fast/forms/basic-textareas.html [ Failure ]
  fast/forms/blankbuttons.html [ Failure ]
  fast/forms/button-generated-content.html [ Failure ]
  fast/forms/button-inner-block-reuse.html [ Failure ]
  fast/forms/control-clip.html [ Failure ]
  fast/forms/fieldset-align.html [ Failure ]
  fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html [ Failure ]
  fast/forms/fieldset-with-float.html [ Failure ]
  fast/forms/float-before-fieldset.html [ Failure ]
  fast/forms/focus-selection-textarea.html [ Failure ]
  fast/forms/indeterminate.html [ Failure ]
  fast/forms/input-appearance-readonly.html [ Failure ]
  fast/forms/input-appearance-visibility.html [ Failure ]
  fast/forms/input-first-letter.html [ Failure ]
  fast/forms/input-readonly-dimmed.html [ Failure ]
  fast/forms/input-spaces.html [ Failure ]
  fast/forms/input-text-click-outside.html [ Failure ]
  fast/forms/input-type-text-min-width.html [ Failure ]
  fast/forms/input-width.html [ Failure ]
  fast/forms/listbox-onchange.html [ FailurNo handlers could be found for logger "webkitpy.port.win"
e ]
  fast/forms/menulist-clip.html [ Failure ]
  fast/forms/menulist-option-wrap.html [ Failure ]
  fast/forms/menulist-separator-painting.html [ Failure ]
  fast/forms/menulist-width-change.html [ Failure ]
  fast/forms/negativeLineHeight.html [ Failure ]
  fast/forms/onselect-textarea.html [ Failure ]
  fast/forms/option-script.html [ Failure ]
  fast/forms/option-text-clip.html [ Failure ]
  fast/forms/placeholder-pseudo-style.html [ Failure ]
  fast/forms/range/input-appearance-range.html [ Failure ]
  fast/forms/range/range-thumb-height-percentage.html [ Failure ]
  fast/forms/range/slider-padding.html [ Failure ]
  fast/forms/range/slider-thumb-shared-style.html [ Failure ]
  fast/forms/range/slider-thumb-stylability.html [ Failure ]
  fast/forms/range/thumbslider-no-parent-slider.html [ Failure ]
  fast/forms/search-cancel-button-style-sharing.html [ Failure ]
  fast/forms/search-display-none-cancel-button.html [ Failure ]
  fast/forms/search-rtl.html [ Failure ]
  fast/forms/search-styled.html [ Failure ]
  fast/forms/search-vertical-alignment.html [ Failure ]
  fast/forms/search/search-size-with-decorations.html [ Failure ]
  fast/forms/select-background-none.html [ Failure ]
  fast/forms/select-empty-option-height.html [ Failure ]
  fast/forms/select-size.html [ Failure ]
  fast/forms/select-visual-hebrew.html [ Failure ]
  fast/forms/select-writing-direction-natural.html [ Failure ]
  fast/forms/selectlist-minsize.html [ Failure ]
  fast/forms/stuff-on-my-optgroup.html [ Failure ]
  fast/forms/textAreaLineHeight.html [ Failure ]
  fast/forms/textarea-align.html [ Failure ]
  fast/forms/textarea-metrics.html [ Failure ]
  fast/forms/textarea-placeholder-pseudo-style.html [ Failure ]
  fast/forms/textarea-placeholder-visibility-1.html [ Failure ]
  fast/forms/textarea-placeholder-visibility-2.html [ Failure ]
  fast/forms/textarea-scroll-height.html [ Failure ]
  fast/forms/textarea-scrollbar.html [ Failure ]
  fast/forms/textarea-scrolled-type.html [ Failure ]
  fast/forms/textarea-setinnerhtml.html [ Failure ]
  fast/forms/textarea-width.html [ Failure ]
  fast/forms/textfield-overflow-by-value-update.html [ Failure ]
  fast/forms/textfield-overflow.html [ Failure ]

Will rebaseline

Comment 1 Roger Fong 2014-10-23 15:04:01 PDT

Rebaselined r175144

Comment 2 Ahmad Saleem 2023-02-09 15:48:08 PST

This landed - https://github.com/WebKit/WebKit/commit/89861c0f19e52bd542f1caaed249684cdcfcba28

and also these rebaseline was for 'win' platform, which is now gone?

Can we close this now?

Comment 3 Brent Fulgham 2023-02-09 16:15:56 PST

(In reply to Ahmad Saleem from comment #2)
> This landed -
> https://github.com/WebKit/WebKit/commit/
> 89861c0f19e52bd542f1caaed249684cdcfcba28
> 
> and also these rebaseline was for 'win' platform, which is now gone?
> 
> Can we close this now?

I'm not sure yet. We still have a Windows port -- we just don't have one that uses a bunch of Apple frameworks that aren't shipped anymore.

Let's leave this open until Don and I hash out all the windows bits.