Bug 138007

Summary: [EFL] Make the EFL Accessibility use a separate web process
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Krzysztof Czech <k.czech>
Status: RESOLVED WONTFIX    
Severity: Normal CC: benjamin, cdumez, gyuyoung.kim, lucas.de.marchi, mcatanzaro, ryuan.choi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
patch gyuyoung.kim: review-

Krzysztof Czech
Reported 2014-10-23 07:25:51 PDT
It's a continuation of r175098. Providing required empty stubs as background for further development.
Attachments
proposed patch (9.71 KB, patch)
2014-10-23 07:33 PDT, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
patch (12.43 KB, patch)
2014-10-31 06:53 PDT, Krzysztof Czech 		gyuyoung.kim: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2014-10-23 07:33:03 PDT
Created attachment 240345 [details] proposed patch
Krzysztof Czech
Comment 2 2014-10-26 13:08:41 PDT
Gyuyoung any chance to get review?
Gyuyoung Kim
Comment 3 2014-10-31 02:28:00 PDT
Comment on attachment 240345 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=240345&action=review Looks fine as initial dummy implementation except for missing license. > Source/WebKit2/WebProcess/WebPage/efl/WebAccessibilityEfl.cpp:1 > +#include "config.h" Missing License. > Source/WebKit2/WebProcess/WebPage/efl/WebAccessibilityEfl.h:1 > +#ifndef WebAccessibilityEfl_h ditto.
Krzysztof Czech
Comment 4 2014-10-31 06:53:28 PDT
Created attachment 240732 [details] patch
Krzysztof Czech
Comment 5 2014-10-31 06:55:15 PDT
(In reply to comment #3) > Comment on attachment 240345 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=240345&action=review > > Looks fine as initial dummy implementation except for missing license. > > > Source/WebKit2/WebProcess/WebPage/efl/WebAccessibilityEfl.cpp:1 > > +#include "config.h" > > Missing License. > > > Source/WebKit2/WebProcess/WebPage/efl/WebAccessibilityEfl.h:1 > > +#ifndef WebAccessibilityEfl_h > > ditto. Done Thanks Gyuyoung
Krzysztof Czech
Comment 6 2014-10-31 07:01:55 PDT
Hi Benjamin would take a look at this. I'm stabbing out some API nothing else, but it modifies some WK2 files.
Gyuyoung Kim
Comment 7 2016-03-09 16:44:29 PST
Comment on attachment 240732 [details] patch r- because this patch should be updated against latest trunk. Kczech please rebase this patch.
Michael Catanzaro
Comment 8 2017-03-11 10:40:00 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.