Bug 138005

Summary: [TexMap] Redundant method in GraphicsLayerTextureMapper.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, bfulgham, cmarcelo, commit-queue, kondapallykalyan, luiz, mrobinson, noam, pnormand, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2014-10-23 04:29:07 PDT
The TextureMapperLayer method descendantsOrSelfHaveRunningAnimations() can be used instead of the GraphicsLayerTextureMapper method startedAnimation().
Attachments
Patch (4.23 KB, patch)
2014-10-23 04:33 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (4.19 KB, patch)
2014-12-02 04:37 PST, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2014-10-23 04:33:48 PDT
Created attachment 240343 [details] Patch
peavo
Comment 2 2014-12-02 04:37:53 PST
Created attachment 242398 [details] Patch
peavo
Comment 3 2014-12-02 04:40:49 PST
(In reply to comment #2) > Created attachment 242398 [details] > Patch Rebased.
Alex Christensen
Comment 4 2014-12-02 13:25:49 PST
This seems ok, but I'd prefer to have someone who knows and works more with texmap review this. Why is startedAnimation there? Is anyone else using it? Were they? Will they?
peavo
Comment 5 2014-12-03 07:33:15 PST
(In reply to comment #4) > This seems ok, but I'd prefer to have someone who knows and works more with > texmap review this. Why is startedAnimation there? Is anyone else using > it? Were they? Will they? Thanks for looking into this :) I added the startedAnimation method as part of the accelerated compositing patch for WinCairo, so I don't think anybody else is using it. It was pointed out to me that there already is a similar method for this.
Alex Christensen
Comment 6 2014-12-03 11:58:49 PST
Comment on attachment 242398 [details] Patch In that case I'll put it in because it appears not to break Linux.
WebKit Commit Bot
Comment 7 2014-12-03 12:37:27 PST
Comment on attachment 242398 [details] Patch Clearing flags on attachment: 242398 Committed r176748: <http://trac.webkit.org/changeset/176748>
WebKit Commit Bot
Comment 8 2014-12-03 12:37:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.