Bug 137987

Summary: Add action menu support for images
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 137995    
Attachments:
Description Flags
patch andersca: review+

Beth Dakin
Reported 2014-10-22 16:11:08 PDT
We should add action menu support for images rdar://problem/18717767
Attachments
patch (113.02 KB, patch)
2014-10-22 16:16 PDT, Tim Horton 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-10-22 16:16:49 PDT
Created attachment 240303 [details] patch some rough edges, but vaguely reviewable (taking the many FIXMEs into account)
WebKit Commit Bot
Comment 2 2014-10-22 16:18:35 PDT
Attachment 240303 [details] did not pass style-queue: ERROR: Unexpected diff format when parsing a chunk: '%\xe2\xe3\xcf\xd3' ERROR: Unexpected diff format when parsing a chunk: '<</Metadata 2 0 R/Pages 3 0 R/Type/Catalog>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '2 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Length 16948/Subtype/XML/Type/Metadata>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '3 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Count 1/Kids[5 0 R]/Type/Pages>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '5 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</ArtBox[0.0 0.0 17.0 16.0]/BleedBox[0.0 0.0 17.0 16.0]/Contents 6 0 R/Group 7 0 R/MediaBox[0.0 0.0 17.0 16.0]/Parent 3 0 R/Resources<</ExtGState<</GS0 8 0 R/GS1 9 0 R>>/Properties<</MC0 10 0 R>>/XObject<</Fm0 11 0 R>>>>/TrimBox[0.0 0.0 17.0 16.0]/Type/Page>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '6 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Filter/FlateDecode/Length 258>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '7 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</CS/DeviceRGB/I false/K false/S/Transparency>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '11 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</BBox[0.0 12.9895 17.0 -0.010498]/Group 12 0 R/Length 222/Matrix[1.0 0.0 0.0 1.0 0.0 0.0]/Resources<</ExtGState<</GS0 8 0 R>>>>/Subtype/Form>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '12 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</I false/K false/S/Transparency/Type/Group>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '8 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 1.0/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 1.0/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '10 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Color[20224 32768 65535]/Dimmed false/Editable true/Preview true/Printed true/Title(Layer 1)/Visible true>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '9 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 0.850006/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 0.850006/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '13 0 obj' ERROR: Unexpected diff format when parsing a chunk: "<</CreationDate(D:20141021131605-07'00')/Creator(Adobe Illustrator CC \\(Macintosh\\))/ModDate(D:20141021131605-07'00')/Producer(Adobe PDF library 11.00)/Title(add to photos \\(edited\\))>>" ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: 'xref' ERROR: Unexpected diff format when parsing a chunk: '0 14' ERROR: Unexpected diff format when parsing a chunk: '0000000000 65535 f' ERROR: Unexpected diff format when parsing a chunk: '<</Size 14/Root 1 0 R/Info 13 0 R/ID[<E2D69684B34C45FEB09C4F193E6EF111><C1B05E620DF14586A358D34222A98938>]>>' ERROR: Unexpected diff format when parsing a chunk: 'startxref' ERROR: Unexpected diff format when parsing a chunk: '18845' ERROR: Unexpected diff format when parsing a chunk: '%%EOF' ERROR: Unexpected diff format when parsing a chunk: '%\xe2\xe3\xcf\xd3' ERROR: Unexpected diff format when parsing a chunk: '<</Metadata 2 0 R/Pages 3 0 R/Type/Catalog>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '2 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Length 12806/Subtype/XML/Type/Metadata>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '3 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Count 1/Kids[5 0 R]/Type/Pages>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '5 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</ArtBox[1.0 1.0 15.0 15.0]/BleedBox[0.0 0.0 16.0 16.0]/Contents 6 0 R/Group 7 0 R/MediaBox[0.0 0.0 16.0 16.0]/Parent 3 0 R/Resources<</ExtGState<</GS0 8 0 R/GS1 9 0 R>>/Properties<</MC0 10 0 R>>/XObject<</Fm0 11 0 R/Fm1 12 0 R>>>>/TrimBox[0.0 0.0 16.0 16.0]/Type/Page>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '6 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Filter/FlateDecode/Length 107>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '7 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</CS/DeviceRGB/I false/K false/S/Transparency>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '11 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</BBox[4.0 15.0 15.0 4.0]/Group 13 0 R/Length 281/Matrix[1.0 0.0 0.0 1.0 0.0 0.0]/Resources<</ExtGState<</GS0 9 0 R>>>>/Subtype/Form>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '12 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</BBox[1.0 12.0 12.0 1.0]/Group 14 0 R/Length 210/Matrix[1.0 0.0 0.0 1.0 0.0 0.0]/Resources<</ExtGState<</GS0 9 0 R>>>>/Subtype/Form>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '14 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</I false/K false/S/Transparency/Type/Group>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '9 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 1.0/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 1.0/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '13 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</I false/K false/S/Transparency/Type/Group>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '10 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Color[20224 32768 65535]/Dimmed false/Editable true/Preview true/Printed true/Title(Layer 1)/Visible true>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '8 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 0.850006/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 0.850006/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '15 0 obj' ERROR: Unexpected diff format when parsing a chunk: "<</CreationDate(D:20141021130137-07'00')/Creator(Adobe Illustrator CC \\(Macintosh\\))/ModDate(D:20141021130137-07'00')/Producer(Adobe PDF library 11.00)/Title(copy)>>" ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: 'xref' ERROR: Unexpected diff format when parsing a chunk: '0 16' ERROR: Unexpected diff format when parsing a chunk: '0000000000 65535 f' ERROR: Unexpected diff format when parsing a chunk: '<</Size 16/Root 1 0 R/Info 15 0 R/ID[<C077BE5010DF4E929DC46952A2AEFB7B><2CCABCCA8F1C4885A81B634350A83CD5>]>>' ERROR: Unexpected diff format when parsing a chunk: 'startxref' ERROR: Unexpected diff format when parsing a chunk: '15036' ERROR: Unexpected diff format when parsing a chunk: '%%EOF' ERROR: Unexpected diff format when parsing a chunk: '%\xe2\xe3\xcf\xd3' ERROR: Unexpected diff format when parsing a chunk: '<</Metadata 2 0 R/Pages 3 0 R/Type/Catalog>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '2 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Length 19798/Subtype/XML/Type/Metadata>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '3 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Count 1/Kids[5 0 R]/Type/Pages>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '5 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</ArtBox[0.0 0.0 16.0 16.0]/BleedBox[0.0 0.0 16.0 16.0]/Contents 6 0 R/MediaBox[0.0 0.0 16.0 16.0]/Parent 3 0 R/Resources<</ExtGState<</GS0 7 0 R>>/Properties<</MC0 8 0 R>>>>/TrimBox[0.0 0.0 16.0 16.0]/Type/Page>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '6 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Filter/FlateDecode/Length 223>>stream' ERROR: Unexpected diff format when parsing a chunk: '\xdd\xcf\xef\xf38a\xb7]3~n\xd6\x08w`\x94\x8f4\x8d\xae\xe9\x08\x07\xfcS*\x8d\xe9\x0c\xdd\xf7\x9e\xf1\xfc\x80;J\xa6\x04\x032\x8d\xc1z\x8c\xb7\xecv\x03c)\x0c^\xa1\x19\x88e@K\xe2\xa4\x1ae\x8f0\x9b\xc2\x14\xc6\x1e\xe7\x10q\xc4\xd6&\xd9\x02"4|\x13\xd2\xca\xbdg\xaa\xe9\xd3\x88\xa9\x1b\x9f/\xb50GNB\xb5\x8d"!\xa7\x95+Z\xca' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '8 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Color[20224 32768 65535]/Dimmed false/Editable true/Preview true/Printed true/Title(Layer 1)/Visible true>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '7 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 1.0/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 1.0/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '9 0 obj' ERROR: Unexpected diff format when parsing a chunk: "<</CreationDate(D:20141021130620-07'00')/Creator(Adobe Illustrator CC \\(Macintosh\\))/ModDate(D:20141021130620-07'00')/Producer(Adobe PDF library 11.00)/Title(save to downloads)>>" ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: 'xref' ERROR: Unexpected diff format when parsing a chunk: '0 10' ERROR: Unexpected diff format when parsing a chunk: '0000000000 65535 f' ERROR: Unexpected diff format when parsing a chunk: '<</Size 10/Root 1 0 R/Info 9 0 R/ID[<D37224960EED4540861D3932BC44E457><56658A77C5754A34BFB896834B48AC10>]>>' ERROR: Unexpected diff format when parsing a chunk: 'startxref' ERROR: Unexpected diff format when parsing a chunk: '20955' ERROR: Unexpected diff format when parsing a chunk: '%%EOF' ERROR: Unexpected diff format when parsing a chunk: '%\xe2\xe3\xcf\xd3' ERROR: Unexpected diff format when parsing a chunk: '<</Metadata 2 0 R/Pages 3 0 R/Type/Catalog>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '2 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Length 11864/Subtype/XML/Type/Metadata>>stream' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '3 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Count 1/Kids[5 0 R]/Type/Pages>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '5 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</ArtBox[2.0 0.0 13.0 15.9964]/BleedBox[0.0 0.0 15.0 16.0]/Contents 6 0 R/MediaBox[0.0 0.0 15.0 16.0]/Parent 3 0 R/Resources<</ExtGState<</GS0 7 0 R>>/Properties<</MC0 8 0 R>>>>/TrimBox[0.0 0.0 15.0 16.0]/Type/Page>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '6 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Filter/FlateDecode/Length 395>>stream' ERROR: Unexpected diff format when parsing a chunk: '\xe6*\x8e\x99\xbb\xd9\x9aw\xe0\xe5\x90\xdf(\xb2/\xae\x97\xde\xa8\xb7\x99s\xed%\x8a\x9d8\x1bO\xaf\xa3\xbf\xc6\xe2ok\x84\x88\xc7Y\xeb\x0c\xde\xb1\xeaH\xeaxW\xbd\xd7\x13\x03\x0e.ZG\xcd\xd1\x96P{\x98\xf6\x97g\xff\x9a^\xd2?\x01\x06\x00V+\xa4\xa9' ERROR: Unexpected diff format when parsing a chunk: 'endstream' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '8 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</Color[20224 32768 65535]/Dimmed false/Editable true/Preview true/Printed true/Title(Layer 1)/Visible true>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '7 0 obj' ERROR: Unexpected diff format when parsing a chunk: '<</AIS false/BM/Normal/CA 1.0/OP false/OPM 1/SA true/SMask/None/Type/ExtGState/ca 1.0/op false>>' ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: '9 0 obj' ERROR: Unexpected diff format when parsing a chunk: "<</CreationDate(D:20141021130402-07'00')/Creator(Adobe Illustrator CC \\(Macintosh\\))/ModDate(D:20141021130402-07'00')/Producer(Adobe PDF library 11.00)/Title(share)>>" ERROR: Unexpected diff format when parsing a chunk: 'endobj' ERROR: Unexpected diff format when parsing a chunk: 'xref' ERROR: Unexpected diff format when parsing a chunk: '0 10' ERROR: Unexpected diff format when parsing a chunk: '0000000000 65535 f' ERROR: Unexpected diff format when parsing a chunk: '<</Size 10/Root 1 0 R/Info 9 0 R/ID[<10653919F0F842C9B46E02AC68A34D9E><EE98C966F3AD4F9286B1727CFEE75677>]>>' ERROR: Unexpected diff format when parsing a chunk: 'startxref' ERROR: Unexpected diff format when parsing a chunk: '13184' ERROR: Unexpected diff format when parsing a chunk: '%%EOF' ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:80: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:3801: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:3908: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:3913: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:3921: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 6 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2014-10-22 16:41:35 PDT
Comment on attachment 240303 [details] patch r=me with the comments we discussed in person.
Tim Horton
Comment 4 2014-10-22 16:49:11 PDT
http://trac.webkit.org/changeset/175075
Tim Horton
Comment 5 2014-10-23 10:47:15 PDT
Follow up fix: http://trac.webkit.org/changeset/175127
Note You need to log in before you can comment on or make changes to this bug.