Bug 137888 – Factor out JITCode::typeName() for debugging use

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Lam]

JITCode's printInternal() currently decodes the JITType into a string and prints it.  This change factors out the part that decodes the JITType into JITCode::typeName() so that we can call it from lldb while debugging to quickly decode a JITType value.

[Mark Lam]

Created attachment 240133 [details]
the patch.

[Geoffrey Garen]

Comment on attachment 240133 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=240133&action=review

> Source/JavaScriptCore/jit/JITCode.cpp:54
> +    case None: return "None";
> +    case HostCallThunk: return "Host";
> +    case InterpreterThunk: return "LLInt";
> +    case BaselineJIT: return "Baseline";
> +    case DFGJIT: return "DFG";
> +    case FTLJIT: return "FTL";

Coding style is wrong here. Please reuse the existing style.

[Mark Lam]

Created attachment 240134 [details]
updated patch

[Geoffrey Garen]

Comment on attachment 240134 [details]
updated patch

r=me

[Mark Lam]

Thanks for the review.  Landed in r174897: <http://trac.webkit.org/r174897>.

[Filip Pizlo]

Comment on attachment 240134 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240134&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        JITCode's printInternal() currently decodes the JITType into a string and
> +        prints it.  This change factors out the part that decodes the JITType into

Why can't lldb call this directly?

> Source/JavaScriptCore/jit/JITCode.cpp:257
> +    out.print("%s", JSC::JITCode::typeName(type));

This is wrong.  PrintStream::print() doesn't take a format string.

[Mark Lam]

Created attachment 242597 [details]
follow up patch to fix use of PrintStream::print().

[Mark Lam]

Comment on attachment 242597 [details]
follow up patch to fix use of PrintStream::print().

Fix already addressed in https://bugs.webkit.org/show_bug.cgi?id=139274.