| Summary: | MacroAssemblerX86Common.cpp should be built on Windows too | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ggaren, mark.lam, oliver, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 137807 | ||||||
| Attachments: |
|
||||||
|
Description
Csaba Osztrogonác
2014-10-20 03:43:28 PDT
Created attachment 240106 [details]
Patch
The goal of this bug report to add MacroAssemblerX86Common.cpp properly to the Windows build system to fix the build in bug137807 . I think ClInclude for this cpp was only a typo, when this file was added to the trunk - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj Additionally it was added to the filter file as ClCompile - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters But it was changed back to ClInclude in http://trac.webkit.org/changeset/153343/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters Comment on attachment 240106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240106&action=review Thanks for catching this. r=me. > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:308 > + <ClCompile Include="..\assembler\MacroAssemblerX86Common.cpp" /> This was definitely a mistake made by someone manually copying/pasting the project file. Comment on attachment 240106 [details] Patch Clearing flags on attachment: 240106 Committed r174887: <http://trac.webkit.org/changeset/174887> All reviewed patches have been landed. Closing bug. |