Bug 137853

Summary:

WorkQueue dispatches functions but isn’t a FunctionDispatcher

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, cmarcelo, commit-queue, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Make WorkQueue a FunctionDispatcher	andersca: review+

Description mitz 2014-10-18 11:20:25 PDT

WorkQueue is a function dispatcher, but it doesn’t inherit from WTF::FunctionDispatcher.

Comment 1 mitz 2014-10-18 11:22:06 PDT

Created attachment 240067 [details]
Make WorkQueue a FunctionDispatcher

Comment 2 WebKit Commit Bot 2014-10-18 11:25:08 PDT

Attachment 240067 [details] did not pass style-queue:


ERROR: Source/WebKit2/Platform/WorkQueue.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2014-10-18 11:32:12 PDT

Comment on attachment 240067 [details]
Make WorkQueue a FunctionDispatcher

View in context: https://bugs.webkit.org/attachment.cgi?id=240067&action=review

> Source/WebKit2/Platform/WorkQueue.h:68
> +    virtual void dispatch(std::function<void ()>) override final;

I'd just make WorkQueue itself final.

Comment 4 mitz 2014-10-18 12:04:52 PDT

Fixed in <http://trac.webkit.org/r174864>.