Bug 137841

Summary: Don't allocate stack slots for captured variables
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: NEW    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
passes all tests but is still just refactoring
none
Patch none

Oliver Hunt
Reported 2014-10-17 16:50:52 PDT
Don't allocate stack slots for captured variables
Attachments
WIP (56.59 KB, patch)
2014-10-17 16:51 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
passes all tests but is still just refactoring (57.24 KB, patch)
2014-10-20 14:30 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (102.93 KB, patch)
2014-10-27 12:16 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2014-10-17 16:51:20 PDT
Created attachment 240052 [details] WIP
Oliver Hunt
Comment 2 2014-10-20 14:30:57 PDT
Created attachment 240146 [details] passes all tests but is still just refactoring
Oliver Hunt
Comment 3 2014-10-27 12:16:03 PDT
Created attachment 240490 [details] Patch
WebKit Commit Bot
Comment 4 2014-10-27 12:18:41 PDT
Attachment 240490 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:542: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1999: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:593: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 46 files If any of these errors are false positives, please file a bug against check-webkit-style.
Michael Catanzaro
Comment 5 2016-09-17 07:03:35 PDT
Comment on attachment 240490 [details] Patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
Note You need to log in before you can comment on or make changes to this bug.