| Summary: | Don't allocate stack slots for captured variables | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||
| Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Oliver Hunt
2014-10-17 16:50:52 PDT
Created attachment 240052 [details]
WIP
Created attachment 240146 [details]
passes all tests but is still just refactoring
Created attachment 240490 [details]
Patch
Attachment 240490 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h:542: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5]
ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:1999: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:156: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:593: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 4 in 46 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 240490 [details]
Patch
Hi,
Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.
To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
|